Re: [HACKERS] CREATE SUBSCRIPTION documentation

2017-06-19 Thread Peter Eisentraut
On 6/19/17 13:28, Jeff Janes wrote:
> I think it would be better to instead reference:
> 
> https://www.postgresql.org/docs/devel/static/logical-replication-security.html
> 
> And on that page, it says:
> 
> "The role used for the replication connection must have
> the |REPLICATION| attribute"
> 
> Should also say something like "or be a superuser".  It is bit tedious
> to say that everywhere, but the docs are supposed to be a bit tedious.

Fixed, thanks!

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] CREATE SUBSCRIPTION documentation

2017-06-19 Thread Jeff Janes
https://www.postgresql.org/docs/devel/static/sql-createsubscription.html

Has the note:

See Section 26.2.5.1

for
details on how to configure access control between the subscription and the
publication instance.

But that section seems to describe authentication for physical, not
logical, replication.  Those two no longer use the same access control
methods.  For logical replication, the role has to have replication
attribute or be a superuser, but the role does not need to have replication
listed in the pg_hba.conf.

I think it would be better to instead reference:

https://www.postgresql.org/docs/devel/static/logical-replication-security.html

And on that page, it says:

"The role used for the replication connection must have the REPLICATION
 attribute"

Should also say something like "or be a superuser".  It is bit tedious to
say that everywhere, but the docs are supposed to be a bit tedious.

Cheers,

Jeff