Re: [HACKERS] Dereferenced pointer checks in data.c of ECPG

2015-02-25 Thread Michael Meskes
A patch is attached, and the issue has been spotted by Coverity. Regards, Thanks, committed. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org Jabber: michael.meskes at gmail dot

[HACKERS] Dereferenced pointer checks in data.c of ECPG

2015-02-24 Thread Michael Paquier
Hi all, ecpg_get_data@data.c is using to null-pointer checks for pval but it happens that we have the guarantee that those pointers are never NULL, see for example this piece of code at the code of ecpg_get_data(): /* pval is a pointer to the value */ if (!pval) {