On Tue, Jan 24, 2012 at 6:27 PM, Vik Reykja vikrey...@gmail.com wrote:
I took my first stab at hacking the sources to fix the bug reported here:
http://archives.postgresql.org/pgsql-bugs/2012-01/msg00152.php
It's such a simple patch but it took me several hours with Google and IRC
and I'm
Robert Haas robertmh...@gmail.com writes:
However, I think we ought to handle
renaming a column symmetrically to adding one.
Yeah, I was thinking the same.
So here's a revised version of your patch that does that.
This looks reasonable to me, except that possibly the new error message
text
On Thu, Jan 26, 2012 at 11:29 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
However, I think we ought to handle
renaming a column symmetrically to adding one.
Yeah, I was thinking the same.
So here's a revised version of your patch that does that.
This
On Thu, Jan 26, 2012 at 17:58, Robert Haas robertmh...@gmail.com wrote:
On Thu, Jan 26, 2012 at 11:29 AM, Tom Lane t...@sss.pgh.pa.us wrote:
This looks reasonable to me, except that possibly the new error message
text could do with a bit more thought. It seems randomly unlike the
normal
On Thu, Jan 26, 2012 at 12:02 PM, Vik Reykja vikrey...@gmail.com wrote:
On Thu, Jan 26, 2012 at 17:58, Robert Haas robertmh...@gmail.com wrote:
On Thu, Jan 26, 2012 at 11:29 AM, Tom Lane t...@sss.pgh.pa.us wrote:
This looks reasonable to me, except that possibly the new error message
text
On Thu, Jan 26, 2012 at 18:47, Robert Haas robertmh...@gmail.com wrote:
OK, committed with that further change.
Thank you, Robert! My first real contribution, even if tiny :-)
Just a small nit to pick, though: Giuseppe Sucameli contributed to this
patch but was not credited in the commit
On Thu, Jan 26, 2012 at 1:13 PM, Vik Reykja vikrey...@gmail.com wrote:
On Thu, Jan 26, 2012 at 18:47, Robert Haas robertmh...@gmail.com wrote:
OK, committed with that further change.
Thank you, Robert! My first real contribution, even if tiny :-)
Just a small nit to pick, though: Giuseppe
Hi Robert,
On Thu, Jan 26, 2012 at 7:59 PM, Robert Haas robertmh...@gmail.com wrote:
On Thu, Jan 26, 2012 at 1:13 PM, Vik Reykja vikrey...@gmail.com wrote:
On Thu, Jan 26, 2012 at 18:47, Robert Haas robertmh...@gmail.com wrote:
OK, committed with that further change.
thank you for the fast
Hi hackers,
the attached patch fixes the problem I explained in pgsql-bugs (forwarded).
It's a trivial problem, so no initial patch design was required.
Hope to see my patch applied.
Thanks for your work.
Regards.
-- Forwarded message --
From: Giuseppe Sucameli
I took my first stab at hacking the sources to fix the bug reported here:
http://archives.postgresql.org/pgsql-bugs/2012-01/msg00152.php
It's such a simple patch but it took me several hours with Google and IRC
and I'm sure I did many things wrong. It seems to work as advertised,
though, so I'm
10 matches
Mail list logo