[HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Jaime Casanova
Hi, Testing the CHECK NOT VALID patch i found $subject... is this intended? -- Jaime Casanova         www.2ndQuadrant.com Professional PostgreSQL: Soporte 24x7 y capacitación -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Dean Rasheed
On 15 June 2011 07:56, Jaime Casanova ja...@2ndquadrant.com wrote: Hi, Testing the CHECK NOT VALID patch i found $subject... is this intended? I just noticed that too, and was about to raise it as a bug. If it is intended, then it's not documented. I noticed it while browsing gram.y, and

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Tom Lane
Dean Rasheed dean.a.rash...@gmail.com writes: On 15 June 2011 07:56, Jaime Casanova ja...@2ndquadrant.com wrote: Testing the CHECK NOT VALID patch i found $subject... is this intended? Aside from the ugliness of the code, we can't just add a ConstraintAttributeSpec to the second block,

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Simon Riggs
On Wed, Jun 15, 2011 at 4:54 PM, Tom Lane t...@sss.pgh.pa.us wrote: Dean Rasheed dean.a.rash...@gmail.com writes: On 15 June 2011 07:56, Jaime Casanova ja...@2ndquadrant.com wrote: Testing the CHECK NOT VALID patch i found $subject... is this intended? Aside from the ugliness of the code, we

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié jun 15 11:54:25 -0400 2011: Dean Rasheed dean.a.rash...@gmail.com writes: On 15 June 2011 07:56, Jaime Casanova ja...@2ndquadrant.com wrote: Testing the CHECK NOT VALID patch i found $subject... is this intended? Aside from the ugliness of the code,

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Jaime Casanova
On Wed, Jun 15, 2011 at 3:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: So is somebody from 2nd Quadrant going to supply a patch to fix this? well, i was going to give it a try... but in a couple of hours... -- Jaime Casanova         www.2ndQuadrant.com Professional PostgreSQL:

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Simon Riggs
On Wed, Jun 15, 2011 at 9:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: So is somebody from 2nd Quadrant going to supply a patch to fix this? My understanding was that your patch had a bug, rather than the existing code. If I misunderstood, please explain the bug. In terms of

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Alvaro Herrera
Excerpts from Simon Riggs's message of mié jun 15 16:31:45 -0400 2011: On Wed, Jun 15, 2011 at 9:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: So is somebody from 2nd Quadrant going to supply a patch to fix this? My understanding was that your patch had a bug, rather than the

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: So is somebody from 2nd Quadrant going to supply a patch to fix this? I'm already on it. The whole patch appears to need some review, considering this is about the fourth major flaw we've found in it. regards, tom lane

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Simon Riggs
On Wed, Jun 15, 2011 at 9:59 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Excerpts from Simon Riggs's message of mié jun 15 16:31:45 -0400 2011: On Wed, Jun 15, 2011 at 9:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: So is somebody from 2nd Quadrant going to supply a patch

Re: [HACKERS] FK NOT VALID can't be deferrable?

2011-06-15 Thread Simon Riggs
On Wed, Jun 15, 2011 at 10:42 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: So is somebody from 2nd Quadrant going to supply a patch to fix this? I'm already on it.  The whole patch appears to need some review, considering this is about the fourth