On Thu, Aug 7, 2014 at 8:20 AM, Jeff Janes jeff.ja...@gmail.com wrote:
It needs to go into 9_4_STABLE as well.
It is worth noticing that the buildfarm is completely in red because
this patch was not backpatched to REL9_4_STABLE:
http://buildfarm.postgresql.org/cgi-bin/show_status.pl
Regards,
--
On Wed, Aug 6, 2014 at 7:20 PM, Jeff Janes jeff.ja...@gmail.com wrote:
On Wed, Aug 6, 2014 at 8:35 AM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Aug 5, 2014 at 6:05 PM, Jeff Janes jeff.ja...@gmail.com wrote:
I think you missed one of the regression tests, see attached
Woops. Thanks,
Robert Haas robertmh...@gmail.com writes:
On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
daniele.varra...@gmail.com wrote:
I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
argument 1: something is wrong: the string is likely to end up in
sentences with other colons so
Tom Lane-2 wrote
Robert Haas lt;
robertmhaas@
gt; writes:
On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
lt;
daniele.varrazzo@
gt; wrote:
I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
argument 1: something is wrong: the string is likely to end up in
David G Johnston david.g.johns...@gmail.com writes:
Tom Lane-2 wrote
Surely that was meant to read invalid number OF arguments. The errhint
is only charitably described as English, as well. I'd suggest something
like Arguments of json_build_object() must be pairs of keys and values.
--- but
On Thu, Aug 7, 2014 at 5:53 PM, Tom Lane t...@sss.pgh.pa.us wrote:
David G Johnston david.g.johns...@gmail.com writes:
Tom Lane-2 wrote
Surely that was meant to read invalid number OF arguments. The
errhint
is only charitably described as English, as well. I'd suggest something
like
On Tue, Aug 5, 2014 at 6:05 PM, Jeff Janes jeff.ja...@gmail.com wrote:
I think you missed one of the regression tests, see attached
Woops. Thanks, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list
On Wed, Aug 6, 2014 at 8:35 AM, Robert Haas robertmh...@gmail.com wrote:
On Tue, Aug 5, 2014 at 6:05 PM, Jeff Janes jeff.ja...@gmail.com wrote:
I think you missed one of the regression tests, see attached
Woops. Thanks, committed.
Thanks.
It needs to go into 9_4_STABLE as well.
Cheers,
On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
daniele.varra...@gmail.com wrote:
I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
argument 1: something is wrong: the string is likely to end up in
sentences with other colons so I'd rather use something is wrong at
On Tue, Aug 5, 2014 at 9:35 AM, Robert Haas robertmh...@gmail.com wrote:
On Sat, Aug 2, 2014 at 9:15 AM, Daniele Varrazzo
daniele.varra...@gmail.com wrote:
I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
argument 1: something is wrong: the string is likely to end up in
I'd definitely replace /arg/argument/. Furthermore I'd avoid the form
argument 1: something is wrong: the string is likely to end up in
sentences with other colons so I'd rather use something is wrong at
argument 1.
Is the patch attached better?
Cheers,
-- Daniele
On Thu, Jul 31, 2014 at 1:57
On Wed, Jul 30, 2014 at 2:59 PM, Daniele Varrazzo
daniele.varra...@gmail.com wrote:
Please find attached a small tweak to a couple of strings found while
updating translations. The %d version is already used elsewhere in the
same file.
Probably not a bad idea, but aren't these strings pretty
Please find attached a small tweak to a couple of strings found while
updating translations. The %d version is already used elsewhere in the
same file.
-- Daniele
diff --git a/src/backend/utils/adt/json.c b/src/backend/utils/adt/json.c
index 2f99908..2aa27cc 100644
---
13 matches
Mail list logo
