Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-24 Thread Masahiko Sawada
On Wed, May 24, 2017 at 7:04 PM, Peter Eisentraut wrote: > On 5/17/17 23:36, Masahiko Sawada wrote: >> The patch looks good to me. >> There are some log messages saying just 'logical replication worker >> for subscription ...' in reread_subscription but should we

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-24 Thread Peter Eisentraut
On 5/20/17 00:58, Alvaro Herrera wrote: > Umm, just skimming here -- this patch shows some LOG messages using > elog() rather than ereport(), which seems bogus to me. Fixed that. > Also: > "logical replication table synchronization worker for subscription > \"%s\", table \"%s\" has

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-24 Thread Peter Eisentraut
On 5/17/17 23:36, Masahiko Sawada wrote: > The patch looks good to me. > There are some log messages saying just 'logical replication worker > for subscription ...' in reread_subscription but should we add 'apply' > to these messages in order for user to distinguish between apply > worker and

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-19 Thread Alvaro Herrera
Umm, just skimming here -- this patch shows some LOG messages using elog() rather than ereport(), which seems bogus to me. Also: "logical replication table synchronization worker for subscription \"%s\", table \"%s\" has started" surely there is a more convenient name than "logical

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-19 Thread Noah Misch
On Thu, May 18, 2017 at 12:36:46PM +0900, Masahiko Sawada wrote: > On Thu, May 18, 2017 at 11:29 AM, Peter Eisentraut > wrote: > > On 5/12/17 00:30, Masahiko Sawada wrote: > >> I got same log messages 'starting logical replication worker for > >> subscription'

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-17 Thread Masahiko Sawada
On Thu, May 18, 2017 at 1:00 AM, Peter Eisentraut wrote: > On 5/17/17 05:15, Masahiko Sawada wrote: >> BTW, why should max_replication_slots be set more than 0 even on the >> subscriber side? It's documented but I could not understand reason. > > Because that

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-17 Thread Masahiko Sawada
On Thu, May 18, 2017 at 11:29 AM, Peter Eisentraut wrote: > On 5/12/17 00:30, Masahiko Sawada wrote: >> I got same log messages 'starting logical replication worker for >> subscription' total 5 times but actually 4 of them mean to launch >> table sync worker and

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-17 Thread Peter Eisentraut
On 5/12/17 00:30, Masahiko Sawada wrote: > I got same log messages 'starting logical replication worker for > subscription' total 5 times but actually 4 of them mean to launch > table sync worker and another one means apply worker. We cannot > distinguish them. Also, I got same log messages

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-17 Thread Peter Eisentraut
On 5/17/17 05:15, Masahiko Sawada wrote: > BTW, why should max_replication_slots be set more than 0 even on the > subscriber side? It's documented but I could not understand reason. Because that setting also controls replication origin tracking slots. -- Peter Eisentraut

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-17 Thread Masahiko Sawada
On Wed, May 17, 2017 at 11:33 AM, Masahiko Sawada wrote: > On Wed, May 17, 2017 at 4:08 AM, Robert Haas wrote: >> On Fri, May 12, 2017 at 12:30 AM, Masahiko Sawada >> wrote: >>> Attached small patch adds relid to these log

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-16 Thread Masahiko Sawada
On Wed, May 17, 2017 at 4:08 AM, Robert Haas wrote: > On Fri, May 12, 2017 at 12:30 AM, Masahiko Sawada > wrote: >> Attached small patch adds relid to these log messages if it's valid. >> I'd like to propose it for PG10 if possible, but since It's

Re: [HACKERS] Improvement in log message of logical replication worker

2017-05-16 Thread Robert Haas
On Fri, May 12, 2017 at 12:30 AM, Masahiko Sawada wrote: > Attached small patch adds relid to these log messages if it's valid. > I'd like to propose it for PG10 if possible, but since It's not a bug > and not an open item we can add it to next CF. To me, it seems

[HACKERS] Improvement in log message of logical replication worker

2017-05-11 Thread Masahiko Sawada
Hi, When I created a subscription with copydata option that corresponds to a publication that includes several tables, I got the following log messages. [7019] LOG: starting logical replication worker for subscription "hoge_sub" [7047] LOG: logical replication apply for subscription hoge_sub