Re: [HACKERS] Incorrect comment in postgres_fdw.c

2014-07-14 Thread Shigeru Hanada
Fujita-san, 2014-07-11 18:22 GMT+09:00 Etsuro Fujita fujita.ets...@lab.ntt.co.jp: I think the following comment for store_returning_result() in postgres_fdw.c is not right. /* PGresult must be released before leaving this function. */ I think PGresult should not be released before

Re: [HACKERS] Incorrect comment in postgres_fdw.c

2014-07-14 Thread Fujii Masao
On Mon, Jul 14, 2014 at 7:31 PM, Shigeru Hanada shigeru.han...@gmail.com wrote: Fujita-san, 2014-07-11 18:22 GMT+09:00 Etsuro Fujita fujita.ets...@lab.ntt.co.jp: I think the following comment for store_returning_result() in postgres_fdw.c is not right. /* PGresult must be released

Re: [HACKERS] Incorrect comment in postgres_fdw.c

2014-07-14 Thread Etsuro Fujita
(2014/07/14 19:46), Fujii Masao wrote: On Mon, Jul 14, 2014 at 7:31 PM, Shigeru Hanada shigeru.han...@gmail.com wrote: Fujita-san, 2014-07-11 18:22 GMT+09:00 Etsuro Fujita fujita.ets...@lab.ntt.co.jp: I think the following comment for store_returning_result() in postgres_fdw.c is not right.

[HACKERS] Incorrect comment in postgres_fdw.c

2014-07-11 Thread Etsuro Fujita
I think the following comment for store_returning_result() in postgres_fdw.c is not right. /* PGresult must be released before leaving this function. */ I think PGresult should not be released before leaving this function *on success* in that function. (I guess the comment has been copied