[HACKERS] Parallel restore checks wrong thread return value?

2011-02-26 Thread Magnus Hagander
in spawn_restore:


child = (HANDLE) _beginthreadex(NULL, 0, (void *) parallel_restore,
args, 
0, NULL);
if (child == 0)


But from my reading of the docs, _beginthreadex() returns -1 on error, not 0.

Bug, or am I reading it wrong?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Parallel restore checks wrong thread return value?

2011-02-26 Thread Magnus Hagander
On Sat, Feb 26, 2011 at 16:51, Magnus Hagander mag...@hagander.net wrote:
 in spawn_restore:


        child = (HANDLE) _beginthreadex(NULL, 0, (void *) parallel_restore,
                                                                        args, 
 0, NULL);
        if (child == 0)


 But from my reading of the docs, _beginthreadex() returns -1 on error, not 0.

 Bug, or am I reading it wrong?

I was.

_beginthread() returns -1 on error, and _beginthreadex() returns 0.

That's just brilliant.

Sorry about the noise.

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers