[HACKERS] Re: [COMMITTERS] pgsql: Process 'die' interrupts while reading/writing from the client s

2015-02-03 Thread Heikki Linnakangas

On 02/03/2015 11:51 PM, Andres Freund wrote:

+ * This is called just after low-level writes. That might be after the read
+ * finished successfully, or it was interrupted via interrupt. 'blocked' tells
+ * us whether the


Looks like you forgot to complete that sentence before pushing...

Also, nightjar is unhappy with this:

TRAP: FailedAssertion(!(InterruptHoldoffCount == 0  CritSectionCount 
== 0), File: 
/pgbuild/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/postgres.c, 
Line: 574)


I think that assertion in ProcessClientWriteInterrupt() should be simply 
removed. ProcessClientWriteInterrupt() copes just fine, i.e. does 
nothing, if we're in a critical section or interrupts are held.


- Heikki



--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [COMMITTERS] pgsql: Process 'die' interrupts while reading/writing from the client s

2015-02-03 Thread Andres Freund
On 2015-02-04 00:47:03 +0200, Heikki Linnakangas wrote:
 On 02/03/2015 11:51 PM, Andres Freund wrote:
 + * This is called just after low-level writes. That might be after the read
 + * finished successfully, or it was interrupted via interrupt. 'blocked' 
 tells
 + * us whether the
 
 Looks like you forgot to complete that sentence before pushing...
 
 Also, nightjar is unhappy with this:
 
 TRAP: FailedAssertion(!(InterruptHoldoffCount == 0  CritSectionCount ==
 0), File:
 /pgbuild/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/postgres.c, Line:
 574)
 
 I think that assertion in ProcessClientWriteInterrupt() should be simply
 removed. ProcessClientWriteInterrupt() copes just fine, i.e. does nothing,
 if we're in a critical section or interrupts are held.

Yea, it really was just a brainfart on my endq. It's perfectly normal to be 
called
that way during error handling...

Greetings,

Andres Freund

-- 
 Andres Freund http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers