Re: [HACKERS] Re: check failure with -DRELCACHE_FORCE_RELEASE -DCLOBBER_FREED_MEMORY
On 03/06/2017 05:14 PM, Tom Lane wrote: > I wrote: >> I fixed that, and the basic regression tests no longer crash outright with >> these settings, but I do see half a dozen errors that all seem to be in >> RLS-related tests. > Those turned out to all be the same bug in DoCopy. "make check-world" > passes for me now with -DRELCACHE_FORCE_RELEASE, but I've only tried > HEAD not the back branches. > > I have tied the back branches. They are good. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: check failure with -DRELCACHE_FORCE_RELEASE -DCLOBBER_FREED_MEMORY
I wrote: > I fixed that, and the basic regression tests no longer crash outright with > these settings, but I do see half a dozen errors that all seem to be in > RLS-related tests. Those turned out to all be the same bug in DoCopy. "make check-world" passes for me now with -DRELCACHE_FORCE_RELEASE, but I've only tried HEAD not the back branches. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: check failure with -DRELCACHE_FORCE_RELEASE -DCLOBBER_FREED_MEMORY
I wrote: > Andrew Dunstan writes: >> On 03/03/2017 02:24 PM, Andrew Dunstan wrote: >>> I have been setting up a buildfarm member with -DRELCACHE_FORCE_RELEASE >>> -DCLOBBER_FREED_MEMORY, settings which Alvaro suggested to me.I got core >>> dumps with these stack traces. The platform is Amazon Linux. >> I have replicated this on a couple of other platforms (Fedora, FreeBSD) >> and back to 9.5. The same failure doesn't happen with buildfarm runs on >> earlier branches, although possibly they don't have the same set of tests. > well, the problem in rebuild_relation() seems pretty blatant: I fixed that, and the basic regression tests no longer crash outright with these settings, but I do see half a dozen errors that all seem to be in RLS-related tests. They all look like something is trying to access an already-closed relcache entry, much like the problem in rebuild_relation(). But I have no time to look closer for the next several days. Stephen, I think this is your turf anyway. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] Re: check failure with -DRELCACHE_FORCE_RELEASE -DCLOBBER_FREED_MEMORY
Andrew Dunstan writes: > On 03/03/2017 02:24 PM, Andrew Dunstan wrote: >> I have been setting up a buildfarm member with -DRELCACHE_FORCE_RELEASE >> -DCLOBBER_FREED_MEMORY, settings which Alvaro suggested to me.I got core >> dumps with these stack traces. The platform is Amazon Linux. > I have replicated this on a couple of other platforms (Fedora, FreeBSD) > and back to 9.5. The same failure doesn't happen with buildfarm runs on > earlier branches, although possibly they don't have the same set of tests. well, the problem in rebuild_relation() seems pretty blatant: /* Close relcache entry, but keep lock until transaction commit */ heap_close(OldHeap, NoLock); /* Create the transient table that will receive the re-ordered data */ OIDNewHeap = make_new_heap(tableOid, tableSpace, OldHeap->rd_rel->relpersistence, ^^^ AccessExclusiveLock); There are two such references after the heap_close. I don't know that those are the only bugs, but this reference is certainly the proximate cause of the crash I'm seeing. Will push a fix in a little bit. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Re: check failure with -DRELCACHE_FORCE_RELEASE -DCLOBBER_FREED_MEMORY
On 03/03/2017 02:24 PM, Andrew Dunstan wrote: > I have been setting up a buildfarm member with -DRELCACHE_FORCE_RELEASE > -DCLOBBER_FREED_MEMORY, settings which Alvaro suggested to me.I got core > dumps with these stack traces. The platform is Amazon Linux. > I have replicated this on a couple of other platforms (Fedora, FreeBSD) and back to 9.5. The same failure doesn't happen with buildfarm runs on earlier branches, although possibly they don't have the same set of tests. cheers andrew -- Andrew Dunstanhttps://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
