Re: [HACKERS] Request to add options to tools/git_changelog

2012-05-02 Thread Bruce Momjian
On Sun, Apr 29, 2012 at 02:06:48PM -0400, Jay Levitt wrote: > Bruce Momjian wrote: > >I am again requesting the addition of options to tools/git_changelog so > >I can more easily produce the release notes. I asked for this during > >9.1 development and it was rejected. I am currently using my own

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-29 Thread Jay Levitt
Bruce Momjian wrote: I am again requesting the addition of options to tools/git_changelog so I can more easily produce the release notes. I asked for this during 9.1 development and it was rejected. I am currently using my own custom version of the tool, but have to merge community improvements

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-27 Thread Bruce Momjian
On Thu, Apr 26, 2012 at 03:19:04PM -0400, Bruce Momjian wrote: > Also consider that A is usually the big, clear commit message, and B,C,D > are just minor adjustments with more brief commits, which might require > adjusting the release note item for feature A. When they are in > newest-first order

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-27 Thread Bruce Momjian
On Thu, Apr 26, 2012 at 03:19:04PM -0400, Bruce Momjian wrote: > On Thu, Apr 26, 2012 at 02:05:23PM -0400, Tom Lane wrote: > > Bruce Momjian writes: > > > I agree adding rarely-used options to a tool doesn't make sense, but the > > > question is what percentage of the git_changelog userbase am I?

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Bruce Momjian
On Thu, Apr 26, 2012 at 02:05:23PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > I agree adding rarely-used options to a tool doesn't make sense, but the > > question is what percentage of the git_changelog userbase am I? > > 50% I think. The only thing that's really concerning me here is t

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Andrew Dunstan
On 04/26/2012 02:54 PM, Robert Haas wrote: On Thu, Apr 26, 2012 at 2:05 PM, Tom Lane wrote: Bruce Momjian writes: I agree adding rarely-used options to a tool doesn't make sense, but the question is what percentage of the git_changelog userbase am I? 50% I think. The only thing that's rea

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Robert Haas
On Thu, Apr 26, 2012 at 2:05 PM, Tom Lane wrote: > Bruce Momjian writes: >> I agree adding rarely-used options to a tool doesn't make sense, but the >> question is what percentage of the git_changelog userbase am I? > > 50% I think.  The only thing that's really concerning me here is that > the r

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Tom Lane
Bruce Momjian writes: > I agree adding rarely-used options to a tool doesn't make sense, but the > question is what percentage of the git_changelog userbase am I? 50% I think. The only thing that's really concerning me here is that the reverse-sort option seems likely to be bug-inducing, and I r

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Bruce Momjian
On Thu, Apr 26, 2012 at 06:59:18PM +0200, Magnus Hagander wrote: > On Thu, Apr 26, 2012 at 18:56, Robert Haas wrote: > > On Thu, Apr 26, 2012 at 1:26 AM, Tom Lane wrote: > >> Bruce Momjian writes: > >>> On Wed, Apr 25, 2012 at 05:09:04PM -0400, Tom Lane wrote: > > --details-after Show branch

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Magnus Hagander
On Thu, Apr 26, 2012 at 18:56, Robert Haas wrote: > On Thu, Apr 26, 2012 at 1:26 AM, Tom Lane wrote: >> Bruce Momjian writes: >>> On Wed, Apr 25, 2012 at 05:09:04PM -0400, Tom Lane wrote: > --details-after Show branch and author info after the commit description >> I don't understand th

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Robert Haas
On Thu, Apr 26, 2012 at 1:26 AM, Tom Lane wrote: > Bruce Momjian writes: >> On Wed, Apr 25, 2012 at 05:09:04PM -0400, Tom Lane wrote: --details-after Show branch and author info after the commit description > >>> I don't understand the point of that. > >> The release notes have the author at

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-26 Thread Bruce Momjian
On Thu, Apr 26, 2012 at 01:26:16AM -0400, Tom Lane wrote: > Bruce Momjian writes: > > On Wed, Apr 25, 2012 at 05:09:04PM -0400, Tom Lane wrote: > >>> --details-after Show branch and author info after the commit description > > >> I don't understand the point of that. > > > The release notes have

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-25 Thread Tom Lane
Bruce Momjian writes: > On Wed, Apr 25, 2012 at 05:09:04PM -0400, Tom Lane wrote: >>> --details-after Show branch and author info after the commit description >> I don't understand the point of that. > The release notes have the author at the end of the text. So? The committer is very often no

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-25 Thread Bruce Momjian
On Wed, Apr 25, 2012 at 05:09:04PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > The attached patch gives you an idea of what I want to add. > > This patch doesn't seem to be against HEAD? Yes, if people approve, I will work on a current patch against HEAD. > > --details-after Show bra

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-25 Thread Tom Lane
Bruce Momjian writes: > The attached patch gives you an idea of what I want to add. This patch doesn't seem to be against HEAD? > --details-after Show branch and author info after the commit description I don't understand the point of that. > --master-only Show commits made exclusive

Re: [HACKERS] Request to add options to tools/git_changelog

2012-04-25 Thread Robert Haas
On Wed, Apr 25, 2012 at 4:04 PM, Bruce Momjian wrote: > I am again requesting the addition of options to tools/git_changelog so > I can more easily produce the release notes.  I asked for this during > 9.1 development and it was rejected.  I am currently using my own > custom version of the tool,

[HACKERS] Request to add options to tools/git_changelog

2012-04-25 Thread Bruce Momjian
I am again requesting the addition of options to tools/git_changelog so I can more easily produce the release notes. I asked for this during 9.1 development and it was rejected. I am currently using my own custom version of the tool, but have to merge community improvements into the tool every ye