Re: [HACKERS] Sort is actually PlanState?

2010-11-01 Thread Hitoshi Harada
2010/11/2 Tom Lane : > Hitoshi Harada writes: >> I wonder why SortState is a ScanState. As far as I know ScanState >> means the node may need projection and/or qualification, or it scans >> some relation, but Sort actually doesn't do such things. > > No, not really.  Per the comment for ScanState:

Re: [HACKERS] Sort is actually PlanState?

2010-11-01 Thread Tom Lane
Hitoshi Harada writes: > I wonder why SortState is a ScanState. As far as I know ScanState > means the node may need projection and/or qualification, or it scans > some relation, but Sort actually doesn't do such things. No, not really. Per the comment for ScanState: *ScanState extends

[HACKERS] Sort is actually PlanState?

2010-11-01 Thread Hitoshi Harada
I wonder why SortState is a ScanState. As far as I know ScanState means the node may need projection and/or qualification, or it scans some relation, but Sort actually doesn't do such things. I also tried to modify SortState as PlanState as in the attached patch and regression test passed. Do I mis