Re: [HACKERS] Updatable view columns

2013-10-19 Thread Dean Rasheed
On 18 October 2013 15:43, Robert Haas wrote: > > Committed. > Excellent. Thank you! And thank you Marko for your thorough review. Regards, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-

Re: [HACKERS] Updatable view columns

2013-10-18 Thread Robert Haas
On Tue, Sep 17, 2013 at 6:16 PM, Marko Tiikkaja wrote: > On 2013-09-17 12:53, Dean Rasheed wrote: >> >> Thanks for the review. Those changes all look sensible to me. >> >> Here's an updated patch incorporating all your fixes, and rebased to >> apply without offsets. > > > Looks good to me. Markin

Re: [HACKERS] Updatable view columns

2013-09-17 Thread Marko Tiikkaja
On 2013-09-17 12:53, Dean Rasheed wrote: Thanks for the review. Those changes all look sensible to me. Here's an updated patch incorporating all your fixes, and rebased to apply without offsets. Looks good to me. Marking this one ready for committer. Regards, Marko Tiikkaja -- Sent via pg

Re: [HACKERS] Updatable view columns

2013-09-16 Thread Marko Tiikkaja
Hi Dean, First of all, thanks for working on this! The patch compiles and applies fine (though with offsets). The feature is in the SQL standard, and further improves an existing feature. Some stuff I've spotted and fixed in the attached patch (hope you don't mind, thought it'd be easier to

Re: [HACKERS] Updatable view columns

2013-08-21 Thread Peter Eisentraut
On Mon, 2013-08-12 at 15:27 +0100, Dean Rasheed wrote: > Attached is a work-in-progress patch to extend auto-updatable views to > support views containing a mix of updatable and non-updatable columns. > This is basically the "columns" part of SQL Feature T111, "Updatable > joins, unions, and column