Re: [HACKERS] Vaccum and analyze counters in pgstat

2010-08-21 Thread Magnus Hagander
On Fri, Aug 20, 2010 at 15:49, Tom Lane t...@sss.pgh.pa.us wrote:
 Magnus Hagander mag...@hagander.net writes:
 Attached is a patch that adds columns to pg_stat_*_tables for number
 of [auto]vacuum and [auto]analyze runs on a table, completing the
 current one that just had the last time these ran. It's particularly
 useful to see how much autovac is doing on the tables, but I included
 the counts of regular vacuum and analyze as well for completeness.

 Comments?

 Looks reasonably sane in a quick read-through.

Applied with suggested documentation changes.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Vaccum and analyze counters in pgstat

2010-08-20 Thread Magnus Hagander
Attached is a patch that adds columns to pg_stat_*_tables for number
of [auto]vacuum and [auto]analyze runs on a table, completing the
current one that just had the last time these ran. It's particularly
useful to see how much autovac is doing on the tables, but I included
the counts of regular vacuum and analyze as well for completeness.

Comments?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


stat_vacuum_counters.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Vaccum and analyze counters in pgstat

2010-08-20 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes:
 Attached is a patch that adds columns to pg_stat_*_tables for number
 of [auto]vacuum and [auto]analyze runs on a table, completing the
 current one that just had the last time these ran. It's particularly
 useful to see how much autovac is doing on the tables, but I included
 the counts of regular vacuum and analyze as well for completeness.

 Comments?

Looks reasonably sane in a quick read-through.

 --- 117,125 
  is a subsystem that supports collection and reporting of information 
 about
  server activity.  Presently, the collector can count accesses to tables
  and indexes in both disk-block and individual-row terms.  It also tracks
 !the total number of rows in each table, and information about vacuum and
 !analyze for each table.  It can also count calls to user-defined 
 functions
 !and the total time spent in each one.
 /para

information about vacuum and analyze actions might read better.

 --- 318,325 
 entrySimilar to structnamepg_stat_all_tables/, but counts 
 actions
 taken so far within the current transaction (which are 
 emphasisnot/
 yet included in structnamepg_stat_all_tables/ and related views).
 !   The columns for numbers of live and dead rows and vacuum and
 !   analyze values are not present in this view./entry
/row

Likewise values - actions here.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers