Re: [HACKERS] Valgrind and shared_buffers (Was: Restore-reliability mode)

2015-11-04 Thread Alvaro Herrera
Peter Geoghegan wrote:
> On Mon, Jul 27, 2015 at 7:12 AM, Alvaro Herrera
>  wrote:
> > I only tried a few tests, for lack of time, and it didn't produce any.
> > (To verify that the whole thing was working properly, I reduced the
> > range of memory made available during PinBuffer and that resulted in a
> > crash immediately).  I am not really familiar with valgrind TBH and just
> > copied a recipe to run postmaster under it, so if someone with more
> > valgrind-fu could verify this, it would be great.
> >
> >
> > This part:
> >
> >> > > > Under CLOBBER_FREED_MEMORY, wipe a shared buffer when its
> >> > > > global pin count falls to zero.
> >
> > can be done without any valgrind, I think.  Any takers?
> 
> It seems like this didn't go anywhere. Any chance that you'll find the
> time to work on this soon?

No.  How about you?  If you or someone else with more valgrind
familiarity than me look it over and think it's correct, I can push it.

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Valgrind and shared_buffers (Was: Restore-reliability mode)

2015-11-03 Thread Peter Geoghegan
On Mon, Jul 27, 2015 at 7:12 AM, Alvaro Herrera
 wrote:
> I only tried a few tests, for lack of time, and it didn't produce any.
> (To verify that the whole thing was working properly, I reduced the
> range of memory made available during PinBuffer and that resulted in a
> crash immediately).  I am not really familiar with valgrind TBH and just
> copied a recipe to run postmaster under it, so if someone with more
> valgrind-fu could verify this, it would be great.
>
>
> This part:
>
>> > > > Under CLOBBER_FREED_MEMORY, wipe a shared buffer when its
>> > > > global pin count falls to zero.
>
> can be done without any valgrind, I think.  Any takers?

It seems like this didn't go anywhere. Any chance that you'll find the
time to work on this soon?

-- 
Peter Geoghegan


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers