Re: [HACKERS] WIP: Aggregation push-down

2017-11-03 Thread Antonin Houska
Antonin Houska wrote: > This is another version of the patch. > shard.tgz demonstrates the typical postgres_fdw use case. One query shows base > scans of base relation's partitions being pushed to shard nodes, the other > pushes down a join and performs aggregation of the join

Re: [HACKERS] WIP: Aggregation push-down

2017-09-11 Thread Ashutosh Bapat
On Fri, Sep 8, 2017 at 7:04 PM, Antonin Houska wrote: > Ashutosh Bapat wrote: > >> On Thu, Aug 17, 2017 at 8:52 PM, Antonin Houska wrote: >> > Antonin Houska wrote: >> > >> >> Antonin Houska

Re: [HACKERS] WIP: Aggregation push-down

2017-09-08 Thread Antonin Houska
Ashutosh Bapat wrote: > On Thu, Aug 17, 2017 at 8:52 PM, Antonin Houska wrote: > > Antonin Houska wrote: > > > >> Antonin Houska wrote: > >> > >> > This is a new version of the patch I presented in [1]. >

Re: [HACKERS] WIP: Aggregation push-down

2017-09-08 Thread Antonin Houska
Jeevan Chalke wrote: > 1. > + if (aggref->aggvariadic || > + aggref->aggdirectargs || aggref->aggorder || > + aggref->aggdistinct || aggref->aggfilter) > > I did not understand, why you are not pushing aggregate in above cases? > Can you please explain?

Re: [HACKERS] WIP: Aggregation push-down

2017-09-07 Thread Merlin Moncure
On Thu, Aug 17, 2017 at 10:22 AM, Antonin Houska wrote: > Antonin Houska wrote: > output type. For other aggregates (like avg()) the remote nodes will have to > return the transient state value in an appropriate form (maybe bytea type), > which does not depend

Re: [HACKERS] WIP: Aggregation push-down

2017-09-07 Thread Ashutosh Bapat
On Thu, Aug 17, 2017 at 8:52 PM, Antonin Houska wrote: > Antonin Houska wrote: > >> Antonin Houska wrote: >> >> > This is a new version of the patch I presented in [1]. >> >> Rebased. >> >> cat .git/refs/heads/master >>

Re: [HACKERS] WIP: Aggregation push-down

2017-09-07 Thread Jeevan Chalke
Hi Antonin, To understand the feature you have proposed, I have tried understanding your patch. Here are few comments so far on it: 1. + if (aggref->aggvariadic || + aggref->aggdirectargs || aggref->aggorder || + aggref->aggdistinct || aggref->aggfilter) I did

Re: [HACKERS] WIP: Aggregation push-down

2017-08-17 Thread Antonin Houska
Antonin Houska wrote: > Antonin Houska wrote: > > > This is a new version of the patch I presented in [1]. > > Rebased. > > cat .git/refs/heads/master > b9a3ef55b253d885081c2d0e9dc45802cab71c7b This is another version of the patch. Besides other