Re: [HACKERS] Your review of pg_receivexlog/pg_basebackup

2011-11-03 Thread Magnus Hagander
On Tue, Nov 1, 2011 at 05:53, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Nov 1, 2011 at 3:08 AM, Magnus Hagander mag...@hagander.net wrote: On Fri, Oct 28, 2011 at 08:46, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Oct 27, 2011 at 11:14 PM, Magnus Hagander mag...@hagander.net

Re: [HACKERS] Your review of pg_receivexlog/pg_basebackup

2011-10-31 Thread Magnus Hagander
On Fri, Oct 28, 2011 at 08:46, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Oct 27, 2011 at 11:14 PM, Magnus Hagander mag...@hagander.net wrote: Here's a version that does this. Turns out this requires a lot less code than what was previously in there, which is always nice. We still need

Re: [HACKERS] Your review of pg_receivexlog/pg_basebackup

2011-10-31 Thread Fujii Masao
On Tue, Nov 1, 2011 at 3:08 AM, Magnus Hagander mag...@hagander.net wrote: On Fri, Oct 28, 2011 at 08:46, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Oct 27, 2011 at 11:14 PM, Magnus Hagander mag...@hagander.net wrote: Here's a version that does this. Turns out this requires a lot less

Re: [HACKERS] Your review of pg_receivexlog/pg_basebackup

2011-10-28 Thread Fujii Masao
On Thu, Oct 27, 2011 at 11:14 PM, Magnus Hagander mag...@hagander.net wrote: Here's a version that does this. Turns out this requires a lot less code than what was previously in there, which is always nice. We still need to solve the other part which is how to deal with the partial files on

Re: [HACKERS] Your review of pg_receivexlog/pg_basebackup

2011-10-27 Thread Magnus Hagander
On Wed, Oct 26, 2011 at 09:52, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: (CC'ing pgsql-hackers, this started as an IM discussion yesterday but really belongs in the archives) On 25.10.2011 23:52, Magnus Hagander wrote: There's a tiny chance to get incomplete xlog files

Re: [HACKERS] Your review of pg_receivexlog/pg_basebackup

2011-10-26 Thread Heikki Linnakangas
(CC'ing pgsql-hackers, this started as an IM discussion yesterday but really belongs in the archives) On 25.10.2011 23:52, Magnus Hagander wrote: There's a tiny chance to get incomplete xlog files with pg_receivexlog if you crash: 1. pg_receivexlog finishes write()ing a file but system