Re: [HACKERS] comment for "fast promote"

2013-08-05 Thread Fujii Masao
On Sat, Aug 3, 2013 at 4:31 PM, Tomonari Katsumata wrote: > Hi, > > I made a patch for REL9_3_STABLE which gets rid of > old promote processing. please check it. > This patch make PostgreSQL do fast promoting(*) always. > (*) which means skipping long checkpoint before increasing > timeline. Than

Re: [HACKERS] comment for "fast promote"

2013-08-03 Thread Tomonari Katsumata
Hi, I made a patch for REL9_3_STABLE which gets rid of old promote processing. please check it. This patch make PostgreSQL do fast promoting(*) always. (*) which means skipping long checkpoint before increasing timeline. And after this, I'll do make another patch for unlinking files which are cre

Re: [HACKERS] comment for "fast promote"

2013-07-29 Thread Fujii Masao
On Sat, Jul 27, 2013 at 6:57 PM, Tomonari Katsumata wrote: > Hi, > > Yes, it prevents PROMOTE_SIGNAL_FILE from remaining even if both promote files exist. >>> The command("unlink(PROMOTE_SIGNAL_FILE)") here is for >>> unusualy case. >>> Because the case is when done both procedures

Re: [HACKERS] comment for "fast promote"

2013-07-27 Thread Euler Taveira
On 27-07-2013 06:57, Tomonari Katsumata wrote: > 1. replicating 3 servers(A,B,C) > A->B->C > ("trigger_file = /tmp/trig" is set in recovery_recovery.conf on B and C.) > > 2. stop server A and promoting server B with "touch /tmp/trig;pg_ctl > promote" > B->C > (/tmp/trig file remains on server B) >

Re: [HACKERS] comment for "fast promote"

2013-07-27 Thread Tomonari Katsumata
Hi, >>> Yes, it prevents PROMOTE_SIGNAL_FILE from remaining even if >>> both promote files exist. >>> >> The command("unlink(PROMOTE_SIGNAL_FILE)") here is for >> unusualy case. >> Because the case is when done both procedures below. >> - user create "promote" file on PGDATA >> - user issue "pg_

Re: [HACKERS] comment for "fast promote"

2013-07-26 Thread Fujii Masao
On Fri, Jul 26, 2013 at 11:19 AM, Tomonari Katsumata wrote: > Hi Fujii-san, > > Thank you for response. > > > (2013/07/25 21:15), Fujii Masao wrote: >> On Thu, Jul 25, 2013 at 5:33 PM, Tomonari Katsumata >> wrote: >>> Hi, >>> >>> Now I'm seeing xlog.c in 93_stable for studying "fast promote", >>>

Re: [HACKERS] comment for "fast promote"

2013-07-25 Thread Tomonari Katsumata
Hi Fujii-san, Thank you for response. (2013/07/25 21:15), Fujii Masao wrote: > On Thu, Jul 25, 2013 at 5:33 PM, Tomonari Katsumata > wrote: >> Hi, >> >> Now I'm seeing xlog.c in 93_stable for studying "fast promote", >> and I have a question. >> >> I think it has an extra unlink command for "pr

Re: [HACKERS] comment for "fast promote"

2013-07-25 Thread Fujii Masao
On Thu, Jul 25, 2013 at 5:33 PM, Tomonari Katsumata wrote: > Hi, > > Now I'm seeing xlog.c in 93_stable for studying "fast promote", > and I have a question. > > I think it has an extra unlink command for "promote" file. > (on 9937 line) > --- > 9934 if (stat(FAST_PROMOTE_SIGNAL_FILE, &stat_bu

[HACKERS] comment for "fast promote"

2013-07-25 Thread Tomonari Katsumata
Hi, Now I'm seeing xlog.c in 93_stable for studying "fast promote", and I have a question. I think it has an extra unlink command for "promote" file. (on 9937 line) --- 9934 if (stat(FAST_PROMOTE_SIGNAL_FILE, &stat_buf) == 0) 9935 { 9936 unlink(FAST_PROMOTE_SIGNAL_FILE); 9937 unlink(PROMOTE_S