Re: [HACKERS] ecpglib use PQconnectdbParams

2012-02-13 Thread Michael Meskes
> Because connect_timeout is a separate libpq connection parameter, but > now it's stuck into "options". It might have worked more or less by > accident before. So it is not an option, right? But the old function accepted it as an option it seems. > It's not clear to me why this only appears on

Re: [HACKERS] ecpglib use PQconnectdbParams

2012-02-08 Thread Tom Lane
Peter Eisentraut writes: > if (IsUnderPostmaster) > ereport(FATAL, > (errcode(ERRCODE_SYNTAX_ERROR), > - errmsg("invalid command-line arguments for > server process"), > +

Re: [HACKERS] ecpglib use PQconnectdbParams

2012-02-08 Thread Peter Eisentraut
On mån, 2012-02-06 at 21:11 +0100, Michael Meskes wrote: > On Fri, Feb 03, 2012 at 01:15:30PM +0100, Christian Ullrich wrote: > > Shouldn't these be [7]? You can have up to 6 items, plus the terminator. > > I take it only keywords have to be [7], right? Committed, thanks for spotting > this. > >

Re: [HACKERS] ecpglib use PQconnectdbParams

2012-02-06 Thread Michael Meskes
On Fri, Feb 03, 2012 at 01:15:30PM +0100, Christian Ullrich wrote: > Shouldn't these be [7]? You can have up to 6 items, plus the terminator. I take it only keywords have to be [7], right? Committed, thanks for spotting this. There seems to be one more problem that I haven't had time to tackle y

Re: [HACKERS] ecpglib use PQconnectdbParams

2012-02-06 Thread Marko Kreen
On Fri, Feb 03, 2012 at 01:15:30PM +0100, Christian Ullrich wrote: > * Peter Eisentraut wrote: > >I noticed ecpglib still uses PQconnectdb() with a craftily assembled > >connection string. Here is a patch to use PQconnectdbParams() instead. > > + const char *conn_keywords[6]; > + const ch

Re: [HACKERS] ecpglib use PQconnectdbParams

2012-02-03 Thread Michael Meskes
On Thu, Feb 02, 2012 at 08:01:48PM +0200, Peter Eisentraut wrote: > I noticed ecpglib still uses PQconnectdb() with a craftily assembled > connection string. Here is a patch to use PQconnectdbParams() instead. Thanks, committed. Will sync as soon as I'm online again. Michael -- Michael Meskes M

Re: [HACKERS] ecpglib use PQconnectdbParams

2012-02-03 Thread Christian Ullrich
* Peter Eisentraut wrote: I noticed ecpglib still uses PQconnectdb() with a craftily assembled connection string. Here is a patch to use PQconnectdbParams() instead. + const char *conn_keywords[6]; + const char *conn_values[6]; Shouldn't these be [7]? You can have up to 6 items,

[HACKERS] ecpglib use PQconnectdbParams

2012-02-02 Thread Peter Eisentraut
I noticed ecpglib still uses PQconnectdb() with a craftily assembled connection string. Here is a patch to use PQconnectdbParams() instead. diff --git i/src/interfaces/ecpg/ecpglib/connect.c w/src/interfaces/ecpg/ecpglib/connect.c index 909ba70..ea69e15 100644 --- i/src/interfaces/ecpg/ecpglib/con