Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-04-14 Thread Peter Eisentraut
On 4/13/17 17:52, Petr Jelinek wrote: > On 12/04/17 06:10, Peter Eisentraut wrote: >> On 3/24/17 10:49, Petr Jelinek wrote: >>> Rebase after table copy patch got committed. >> >> You could please sent another rebase of this, perhaps with some more >> documentation, as discussed downthread. >> >>

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-04-13 Thread Petr Jelinek
On 12/04/17 06:10, Peter Eisentraut wrote: > On 3/24/17 10:49, Petr Jelinek wrote: >> Rebase after table copy patch got committed. > > You could please sent another rebase of this, perhaps with some more > documentation, as discussed downthread. > > Also, I wonder why we don't offer the other

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-04-12 Thread Peter Eisentraut
On 4/9/17 22:17, Noah Misch wrote: > [Action required within three days. This is a generic notification.] I'm expecting Petr to post an updated patch by the end of this week. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-04-11 Thread Peter Eisentraut
On 3/24/17 10:49, Petr Jelinek wrote: > Rebase after table copy patch got committed. You could please sent another rebase of this, perhaps with some more documentation, as discussed downthread. Also, I wonder why we don't offer the other values of synchronous_commit. In any case, we should keep

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-04-09 Thread Noah Misch
On Thu, Apr 06, 2017 at 01:38:41PM -0400, Peter Eisentraut wrote: > On 3/24/17 10:49, Petr Jelinek wrote: > > On 07/03/17 06:23, Petr Jelinek wrote: > >> there has been discussion at the logical replication initial copy > >> thread > >> [1] about making apply work with sync commit

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-04-06 Thread Craig Ringer
On 7 April 2017 at 01:38, Peter Eisentraut wrote: > I think this change could use some more documentation. Under what > circumstances would a user want to turn this back on? The main reason is if you want to use synchronous_standby_names and synchronous commit

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-04-06 Thread Peter Eisentraut
On 3/24/17 10:49, Petr Jelinek wrote: > On 07/03/17 06:23, Petr Jelinek wrote: >> there has been discussion at the logical replication initial copy thread >> [1] about making apply work with sync commit off by default for >> performance reasons and adding option to change that per

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-03-26 Thread Masahiko Sawada
On Fri, Mar 24, 2017 at 11:49 PM, Petr Jelinek wrote: > On 21/03/17 22:37, Petr Jelinek wrote: >> On 21/03/17 18:54, Robert Haas wrote: >>> On Mon, Mar 20, 2017 at 7:56 PM, Petr Jelinek >>> wrote: On 18/03/17 13:31, Petr Jelinek

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-03-24 Thread Petr Jelinek
On 21/03/17 22:37, Petr Jelinek wrote: > On 21/03/17 18:54, Robert Haas wrote: >> On Mon, Mar 20, 2017 at 7:56 PM, Petr Jelinek >> wrote: >>> On 18/03/17 13:31, Petr Jelinek wrote: On 07/03/17 06:23, Petr Jelinek wrote: > there has been discussion at the

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-03-21 Thread Petr Jelinek
On 21/03/17 18:54, Robert Haas wrote: > On Mon, Mar 20, 2017 at 7:56 PM, Petr Jelinek > wrote: >> On 18/03/17 13:31, Petr Jelinek wrote: >>> On 07/03/17 06:23, Petr Jelinek wrote: there has been discussion at the logical replication initial copy thread [1]

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-03-21 Thread Robert Haas
On Mon, Mar 20, 2017 at 7:56 PM, Petr Jelinek wrote: > On 18/03/17 13:31, Petr Jelinek wrote: >> On 07/03/17 06:23, Petr Jelinek wrote: >>> there has been discussion at the logical replication initial copy thread >>> [1] about making apply work with sync commit off

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-03-20 Thread Petr Jelinek
On 18/03/17 13:31, Petr Jelinek wrote: > On 07/03/17 06:23, Petr Jelinek wrote: >> Hi, >> >> there has been discussion at the logical replication initial copy thread >> [1] about making apply work with sync commit off by default for >> performance reasons and adding option to change that per

Re: [HACKERS] logical replication apply to run with sync commit off by default

2017-03-18 Thread Petr Jelinek
On 07/03/17 06:23, Petr Jelinek wrote: > Hi, > > there has been discussion at the logical replication initial copy thread > [1] about making apply work with sync commit off by default for > performance reasons and adding option to change that per subscription. > > Here I propose patch to

[HACKERS] logical replication apply to run with sync commit off by default

2017-03-06 Thread Petr Jelinek
Hi, there has been discussion at the logical replication initial copy thread [1] about making apply work with sync commit off by default for performance reasons and adding option to change that per subscription. Here I propose patch to implement this - it adds boolean column subssynccommit to