On 2017/08/04 10:00, Amit Langote wrote:
On 2017/08/04 1:06, Robert Haas wrote:
On Thu, Aug 3, 2017 at 4:40 AM, Etsuro Fujita
wrote:
On 2017/08/03 17:12, Amit Langote wrote:
Attached updated patches.
Thanks for the patch! That looks good to me.
Committed with some comment changes.
Than
On 2017/08/04 1:06, Robert Haas wrote:
> On Thu, Aug 3, 2017 at 4:40 AM, Etsuro Fujita
> wrote:
>> On 2017/08/03 17:12, Amit Langote wrote:
>>> Attached updated patches.
>>
>> Thanks for the patch! That looks good to me.
>
> Committed with some comment changes.
Thanks a lot.
Regards,
Amit
On Thu, Aug 3, 2017 at 4:40 AM, Etsuro Fujita
wrote:
> On 2017/08/03 17:12, Amit Langote wrote:
>> Attached updated patches.
>
> Thanks for the patch! That looks good to me.
Committed with some comment changes.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL
On 2017/08/03 17:12, Amit Langote wrote:
Attached updated patches.
Thanks for the patch! That looks good to me.
Best regards,
Etsuro Fujita
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-h
Fujita-san,
Thanks for the review.
On 2017/08/03 16:01, Etsuro Fujita wrote:
> On 2017/08/02 15:21, Amit Langote wrote:
>> On 2017/08/02 1:33, Amit Khandekar wrote:
>>> ---
>>>
>>> Few more comments :
>>>
>>> @@ -1240,7 +1247,7 @@ map_variable_attnos_mutator(Node *node,
>>> var->varlevelsup
On 2017/08/02 15:21, Amit Langote wrote:
Thanks Fuita-san and Amit for reviewing.
On 2017/08/02 1:33, Amit Khandekar wrote:
On 1 August 2017 at 15:11, Etsuro Fujita wrote:
On 2017/07/31 18:56, Amit Langote wrote:
Yes, that's what's needed here. So we need to teach
map_variable_attnos_mutato
On 3 August 2017 at 11:00, Amit Langote wrote:
> Thanks for the review.
>
> On 2017/08/03 13:54, Amit Khandekar wrote:
>> On 2 August 2017 at 11:51, Amit Langote wrote:
>>> On 2017/08/02 1:33, Amit Khandekar wrote:
Instead of callers of map_partition_varattnos() reporting error, we
can h
Thanks for the review.
On 2017/08/03 13:54, Amit Khandekar wrote:
> On 2 August 2017 at 11:51, Amit Langote wrote:
>> On 2017/08/02 1:33, Amit Khandekar wrote:
>>> Instead of callers of map_partition_varattnos() reporting error, we
>>> can have map_partition_varattnos() itself report error. Instea
On 2 August 2017 at 11:51, Amit Langote wrote:
> Thanks Fuita-san and Amit for reviewing.
>
> On 2017/08/02 1:33, Amit Khandekar wrote:
>> On 1 August 2017 at 15:11, Etsuro Fujita wrote:
>>> On 2017/07/31 18:56, Amit Langote wrote:
Yes, that's what's needed here. So we need to teach
ma
On 2017/08/03 12:06, Robert Haas wrote:
On Wed, Aug 2, 2017 at 2:25 AM, Amit Langote
wrote:
On 2017/08/02 15:21, Amit Langote wrote:
Thanks Fuita-san and Amit for reviewing.
Sorry, I meant Fujita-san.
Time is growing short here. Is there more review or coding that needs
to be done here?
On Wed, Aug 2, 2017 at 2:25 AM, Amit Langote
wrote:
> On 2017/08/02 15:21, Amit Langote wrote:
>> Thanks Fuita-san and Amit for reviewing.
>
> Sorry, I meant Fujita-san.
Time is growing short here. Is there more review or coding that needs
to be done here?
--
Robert Haas
EnterpriseDB: http://w
On 2017/08/02 15:21, Amit Langote wrote:
> Thanks Fuita-san and Amit for reviewing.
Sorry, I meant Fujita-san.
- Amit
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Thanks Fuita-san and Amit for reviewing.
On 2017/08/02 1:33, Amit Khandekar wrote:
> On 1 August 2017 at 15:11, Etsuro Fujita wrote:
>> On 2017/07/31 18:56, Amit Langote wrote:
>>> Yes, that's what's needed here. So we need to teach
>>> map_variable_attnos_mutator() to convert whole-row vars jus
On 1 August 2017 at 15:11, Etsuro Fujita wrote:
> On 2017/07/31 18:56, Amit Langote wrote:
>> Yes, that's what's needed here. So we need to teach
>> map_variable_attnos_mutator() to convert whole-row vars just like it's
>> done in adjust_appendrel_attrs_mutator().
>
>
> Seems reasonable. (Though
On 2017/07/31 18:56, Amit Langote wrote:
On 2017/07/28 20:46, Amit Khandekar wrote:
create table foo (a int, b text) partition by list (a);
create table foo1 partition of foo for values in (1);
create table foo2(b text, a int) ;
alter table foo attach partition foo2 for values in (2);
postgres=
Thanks a lot Amit for looking at this and providing some useful pointers.
On 2017/07/28 20:46, Amit Khandekar wrote:
> On 28 July 2017 at 11:17, Amit Langote wrote:
>> On 2017/07/26 16:58, Amit Langote wrote:
>>> Rajkumar Raghuwanshi reported [1] on the "UPDATE partition key" thread
>>> that whol
On Fri, Jul 28, 2017 at 3:26 PM, Tom Lane wrote:
>> (Boy, our implementation of DROP COLUMN is painful! If we really got
>> rid of columns when they were dropped we could've avoided this whole
>> mess.)
>
> I think the pain arises mostly from the decision to allow partitions
> to not all have ide
Robert Haas writes:
> If we're remapping the varattnos, I don't see how we can just pass
> whole-row references through. I mean, if the partition and the parent
> have different varattnos, then a whole-row attribute for one is a
> different thing from a whole-row attribute for the other; the
> He
Robert Haas wrote:
(Boy, our implementation of DROP COLUMN is painful! If we really got
rid of columns when they were dropped we could've avoided this whole
mess.)
I tend to agree. I can recall several cases where it led to bugs that
went undetected for quite a while.
--
Peter Geoghegan
--
On Fri, Jul 28, 2017 at 1:06 AM, Noah Misch wrote:
> [Action required within three days. This is a generic notification.]
>
> The above-described topic is currently a PostgreSQL 10 open item. Robert,
> since you committed the patch believed to have created it, you own this open
> item. If some
On 28 July 2017 at 11:17, Amit Langote wrote:
> On 2017/07/26 16:58, Amit Langote wrote:
>> Rajkumar Raghuwanshi reported [1] on the "UPDATE partition key" thread
>> that whole-row vars don't play nicely with partitioned table operations.
>>
>> For example, when used to convert WITH CHECK OPTION c
On 2017/07/26 16:58, Amit Langote wrote:
> Rajkumar Raghuwanshi reported [1] on the "UPDATE partition key" thread
> that whole-row vars don't play nicely with partitioned table operations.
>
> For example, when used to convert WITH CHECK OPTION constraint expressions
> and RETURNING target list ex
On Wed, Jul 26, 2017 at 04:58:08PM +0900, Amit Langote wrote:
> Rajkumar Raghuwanshi reported [1] on the "UPDATE partition key" thread
> that whole-row vars don't play nicely with partitioned table operations.
>
> For example, when used to convert WITH CHECK OPTION constraint expressions
> and RET
Rajkumar Raghuwanshi reported [1] on the "UPDATE partition key" thread
that whole-row vars don't play nicely with partitioned table operations.
For example, when used to convert WITH CHECK OPTION constraint expressions
and RETURNING target list expressions, it will error out if the
expressions con
24 matches
Mail list logo
