Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Andrew Dunstan
On 06/21/2017 02:25 PM, Tom Lane wrote: > Andrew Dunstan writes: >> On 06/21/2017 11:30 AM, Tom Lane wrote: >>> Andrew Dunstan writes: Unfortunately this seems precluded by the use of the non-standard "err.h". It looks

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Tom Lane
Andrew Dunstan writes: > On 06/21/2017 11:30 AM, Tom Lane wrote: >> Andrew Dunstan writes: >>> Unfortunately this seems precluded by the use of the non-standard >>> "err.h". It looks like that will trip us up on mingw also. >> Hm,

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Andrew Dunstan
On 06/21/2017 11:30 AM, Tom Lane wrote: > Andrew Dunstan writes: >> Unfortunately this seems precluded by the use of the non-standard >> "err.h". It looks like that will trip us up on mingw also. > Hm, why? Doesn't the -I search path get the right thing? > >

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Tom Lane
Andres Freund writes: > On 2017-06-20 20:30:34 -0400, Tom Lane wrote: >> Well, *I* don't care, but I thought we wanted to support Windows-using >> developers as reasonably first-class citizens. > The old one didn't have windows support either, right? Not that I was aware of,

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Andres Freund
On 2017-06-20 20:30:34 -0400, Tom Lane wrote: > Michael Paquier writes: > > On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane wrote: > >> Yeah, I thought it would work fine with Makefile-using Windows toolchains. > >> But people who use MSVC need something

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Tom Lane
Andrew Dunstan writes: > Unfortunately this seems precluded by the use of the non-standard > "err.h". It looks like that will trip us up on mingw also. Hm, why? Doesn't the -I search path get the right thing? regards, tom lane -- Sent

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Andrew Dunstan
On 06/21/2017 08:20 AM, Andrew Dunstan wrote: > > On 06/20/2017 08:30 PM, Tom Lane wrote: >> Michael Paquier writes: >>> On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane wrote: Yeah, I thought it would work fine with Makefile-using Windows

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-21 Thread Andrew Dunstan
On 06/20/2017 08:30 PM, Tom Lane wrote: > Michael Paquier writes: >> On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane wrote: >>> Yeah, I thought it would work fine with Makefile-using Windows toolchains. >>> But people who use MSVC need something else,

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-20 Thread Tom Lane
Michael Paquier writes: > On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane wrote: >> Yeah, I thought it would work fine with Makefile-using Windows toolchains. >> But people who use MSVC need something else, no? > Are there that many anyway who care?

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-20 Thread Michael Paquier
On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane wrote: > Yeah, I thought it would work fine with Makefile-using Windows toolchains. > But people who use MSVC need something else, no? Are there that many anyway who care? Personally I already fallback to Linux when it comes to

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-20 Thread Tom Lane
Andrew Dunstan writes: > On 06/20/2017 04:17 PM, Tom Lane wrote: >> There's no Windows support yet, and I won't be writing that, >> but I hope someone else will. > What extra support do you think it needs? I have built it on Cygwin > without touching a line of

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-20 Thread Andrew Dunstan
On 06/20/2017 04:17 PM, Tom Lane wrote: > I've set up a repo on our git server for the new improved version > of pg_bsd_indent. Please test it for portability to your favorite > platform(s) by doing > > git clone https://git.postgresql.org/git/pg_bsd_indent.git > cd pg_bsd_indent > make -s all

[HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

2017-06-20 Thread Tom Lane
I've set up a repo on our git server for the new improved version of pg_bsd_indent. Please test it for portability to your favorite platform(s) by doing git clone https://git.postgresql.org/git/pg_bsd_indent.git cd pg_bsd_indent make -s all make check Note you will need a PG installation in