On Mon, Dec 12, 2016 at 6:17 PM, Heikki Linnakangas wrote:
> Removed that, did some further cosmetic changes, and pushed. I renamed a
> bunch variables and structs, so that they are more consistent with the
> similar digest stuff.
That definitely makes sense this way, thanks for the commit.
--
M
On 12/12/2016 07:18 AM, Michael Paquier wrote:
On Fri, Dec 9, 2016 at 10:22 AM, Michael Paquier
wrote:
Thanks for looking at the patch. Looking forward to hearing more!
Here is an updated patch based on which reviews should be done. I have
fixed the issue you have reported, and upon additiona
On Fri, Dec 9, 2016 at 10:22 AM, Michael Paquier
wrote:
> Thanks for looking at the patch. Looking forward to hearing more!
Here is an updated patch based on which reviews should be done. I have
fixed the issue you have reported, and upon additional lookup I have
noticed that returning -1 when fa
On Fri, Dec 9, 2016 at 1:11 AM, Asif Naeem wrote:
> It make sense. I would like to share more comments as following i.e.
>
>> static int
>> bf_check_supported_key_len(void)
>> {
>> ...
>> /* encrypt with 448bits key and verify output */
>> evp_ctx = EVP_CIPHER_CTX_new();
>> if (!evp
It make sense. I would like to share more comments as following i.e.
static int
> bf_check_supported_key_len(void)
> {
> ...
> /* encrypt with 448bits key and verify output */
> evp_ctx = EVP_CIPHER_CTX_new();
> if (!evp_ctx)
> return 1;
> if (!EVP_EncryptInit_ex(evp_
On Tue, Dec 6, 2016 at 11:42 PM, Asif Naeem wrote:
> Thanks for updated patch. Although EVP_CIPHER_CTX_cleanup() seems deprecated
> in OpenSSL >= 1.1.0 i.e.
>
>> # if OPENSSL_API_COMPAT < 0x1010L
>> # define EVP_CIPHER_CTX_init(c) EVP_CIPHER_CTX_reset(c)
>> # define EVP_CIPHER_CTX_clean
Thanks for updated patch. Although EVP_CIPHER_CTX_cleanup() seems deprecated in
OpenSSL >= 1.1.0 i.e.
# if OPENSSL_API_COMPAT < 0x1010L
> # define EVP_CIPHER_CTX_init(c) EVP_CIPHER_CTX_reset(c)
> # define EVP_CIPHER_CTX_cleanup(c) EVP_CIPHER_CTX_reset(c)
> # endif
I guess use of dep
On Tue, Dec 6, 2016 at 9:31 PM, Asif Naeem wrote:
> Thank you for v2 patch, I would like to comment on it. It seems that you
> have used function EVP_CIPHER_CTX_reset in the patch that was introduced in
> OpenSSL 1.1.0, older library version might not work now, is it intentional
> change ?.
I tho
Hi Michael,
Thank you for v2 patch, I would like to comment on it. It seems that you
have used function EVP_CIPHER_CTX_reset in the patch that was introduced in
OpenSSL 1.1.0, older library version might not work now, is it intentional
change ?.
Regards,
Muhammad Asif Naeem
On Tue, Dec 6, 2016 a
On Mon, Dec 5, 2016 at 6:09 PM, Michael Paquier
wrote:
> On Mon, Dec 5, 2016 at 5:11 PM, Heikki Linnakangas wrote:
>> I'm afraid if we just start using EVP_CIPHER_CTX_new(), we'll leak the
>> context on any error. We had exactly the same problem with EVP_MD_CTX_init
>> being removed, in the patch
On Mon, Dec 5, 2016 at 5:11 PM, Heikki Linnakangas wrote:
> I'm afraid if we just start using EVP_CIPHER_CTX_new(), we'll leak the
> context on any error. We had exactly the same problem with EVP_MD_CTX_init
> being removed, in the patch that added OpenSSL 1.1.0 support. We'll have to
> use a reso
On 12/05/2016 05:19 AM, Michael Paquier wrote:
On Thu, Dec 1, 2016 at 11:17 AM, Andreas Karlsson wrote:
On 12/01/2016 02:48 AM, Andres Freund wrote:
Yes, I believe this is one of the changes in OpenSSL 1.1. I guess you might
be the first one to try to compile with 1.1 since
5ff4a67f63fd6d3eb01f
On Thu, Dec 1, 2016 at 11:17 AM, Andreas Karlsson wrote:
> On 12/01/2016 02:48 AM, Andres Freund wrote:
>>
>> It appears openssl has removed the public definition of EVP_CIPHER_CTX
>> leading to pgcrypto failing with:
That's not much surprising, most distributions are still on 1.0.2 as
1.1.0 has
On 12/01/2016 02:48 AM, Andres Freund wrote:
It appears openssl has removed the public definition of EVP_CIPHER_CTX
leading to pgcrypto failing with:
Yes, I believe this is one of the changes in OpenSSL 1.1. I guess you
might be the first one to try to compile with 1.1 since
5ff4a67f63fd6d3eb
Hi,
It appears openssl has removed the public definition of EVP_CIPHER_CTX
leading to pgcrypto failing with:
/home/andres/src/postgresql/contrib/pgcrypto/openssl.c:253:17: error: field
‘evp_ctx’ has incomplete type
EVP_CIPHER_CTX evp_ctx;
^~~
/home/andres/src/postgresql/co
15 matches
Mail list logo
