Robert Haas writes:
> Thanks for the review. New version attached.
This looks sane to me too (though I only read the patch and didn't
actually test upgrading).
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to yo
On Mon, Nov 7, 2011 at 2:37 PM, Tom Lane wrote:
> Robert Haas writes:
>> Thanks for the review. New version attached.
>
> This looks sane to me too (though I only read the patch and didn't
> actually test upgrading).
OK, committed.
Thanks for the reviews, all.
--
Robert Haas
EnterpriseDB: ht
On Thu, Nov 3, 2011 at 10:18 AM, Dimitri Fontaine
wrote:
> Robert Haas writes:
>> Hmm, I was kind of expecting that to be wrong at least in some minor way.
>
>> +/* contrib/hstore/hstore-1.0-1.1.sql */
>> +
>> +-- complain if script is sourced in psql, rather than via CREATE EXTENSION
>> +\echo U
Robert Haas writes:
> Hmm, I was kind of expecting that to be wrong at least in some minor way.
> +/* contrib/hstore/hstore-1.0-1.1.sql */
> +
> +-- complain if script is sourced in psql, rather than via CREATE EXTENSION
> +\echo Use "ALTER EXTENSION hstore" to load this file. \quit
You could me
On Wed, Nov 2, 2011 at 12:36 AM, David E. Wheeler wrote:
> On Nov 1, 2011, at 11:19 AM, Robert Haas wrote:
>>> Fair enough.
>>
>> So, I tried to work up a patch for this, but I'm actually a bit
>> confused about what needs to be done here. I'll attach what I've got
>> so far as a starting point f
On Nov 1, 2011, at 11:19 AM, Robert Haas wrote:
>> Fair enough.
>
> So, I tried to work up a patch for this, but I'm actually a bit
> confused about what needs to be done here. I'll attach what I've got
> so far as a starting point for discussion.
Looks reasonable, if verbose. (Yes, the extensi
On Thu, Oct 6, 2011 at 12:46 PM, Tom Lane wrote:
> Robert Haas writes:
>> +1. However, if that's the route we're traveling down, I think we had
>> better go ahead and remove the one remaining => operator from hstore
>> in 9.2:
>
> Fair enough.
So, I tried to work up a patch for this, but I'm ac
