Re: [HACKERS] sa_family_t in cygwin compile of cvs + regression failure

2003-06-24 Thread Jason Tishler 
Bruce,

On Mon, Jun 23, 2003 at 09:50:49PM -0400, Bruce Momjian wrote:
 OK, patch applied to typedef sa_family_t for cygwin.  If other
 platforms need it, I will have to do something more generic.

I'm happy to report that the above patch solves one of Cygwin's current
build problems.  However, Cygwin still needs the following patch:

http://archives.postgresql.org/pgsql-patches/2003-06/msg00186.php

Thanks,
Jason

-- 
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D  8784 1AFD E4CC ECF4 8EF6

---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html

Re: [HACKERS] sa_family_t in cygwin compile of cvs + regression failure

2003-06-23 Thread Bruce Momjian 

You might still have a problem with compiling getaddrinfo.c.  Please let
me know and I can correct it.

---

deststar wrote:
 On cygwin sa_family_t was undeclared, adding the following line:
 typedef unsigned short sa_family_t;
 to both:
 src/port/getaddrinfo.c
 src/include/libpq/pqcomm.h
 seemed to compile ok but with make check there was one regression 
 failure in test privileges (doesn't look realted, but I'm not sure).
 Also included for ease of testing is a patch sepratly sent to patches 
 for ecpg.
 System: Athalon + Win 2k + cygwin 1.3.22 + gcc 3.2

 *** ./expected/privileges.out Wed May 14 04:26:04 2003
 --- ./results/privileges.out  Sun Jun 15 16:12:34 2003
 ***
 *** 10,18 
 --- 10,22 
   CREATE GROUP regressgroup1;
   CREATE GROUP regressgroup2 WITH USER regressuser1, regressuser2;
   ALTER GROUP regressgroup1 ADD USER regressuser4;
 + WARNING:  AbortTransaction and not in in-progress state
 + ERROR:  rename 
 /home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group.2284
  to 
 /home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group: 
 Permission denied
   ALTER GROUP regressgroup2 ADD USER regressuser2;-- duplicate
   WARNING:  ALTER GROUP: user regressuser2 is already in group regressgroup2
   ALTER GROUP regressgroup2 DROP USER regressuser2;
 + WARNING:  AbortTransaction and not in in-progress state
 + ERROR:  rename 
 /home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group.2284
  to 
 /home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group: 
 Permission denied
   ALTER GROUP regressgroup2 ADD USER regressuser4;
   -- test owner privileges
   SET SESSION AUTHORIZATION regressuser1;
 
 ==
 

 *** src/interfaces/ecpg/compatlib/Makefile.orig   Thu May 22 18:20:44 2003
 --- src/interfaces/ecpg/compatlib/MakefileSun Jun 15 15:45:34 2003
 ***
 *** 17,23 
   SO_MINOR_VERSION= 0.0
   
   override CPPFLAGS := -I$(top_srcdir)/src/interfaces/ecpg/include 
 -I$(top_srcdir)/src/include/utils $(CPPFLAGS)
 ! SHLIB_LINK = -L../pgtypeslib -lpgtypes
   
   OBJS= informix.o
   
 --- 17,23 
   SO_MINOR_VERSION= 0.0
   
   override CPPFLAGS := -I$(top_srcdir)/src/interfaces/ecpg/include 
 -I$(top_srcdir)/src/include/utils $(CPPFLAGS)
 ! SHLIB_LINK = -L../pgtypeslib -lpgtypes -L../ecpglib -lecpg
   
   OBJS= informix.o
   

 
 ---(end of broadcast)---
 TIP 2: you can get off all lists at once with the unregister command
 (send unregister YourEmailAddressHere to [EMAIL PROTECTED])

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [HACKERS] sa_family_t in cygwin compile of cvs + regression failure

2003-06-23 Thread deststar 
I still seem to get a compile problem (included below).
Will double check tomorrow when not so tired (02:15 here).
Cheers,
- Stuart
P.S. My server seems to be blacklisted as a spam server by you. Please 
could you white list me.

gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations 
-I../../../../src/i
nclude  -DBUILDING_DLL  -c -o printtup.o printtup.c -MMD
In file included from ../../../../src/include/libpq/libpq-be.h:22,
 from ../../../../src/include/libpq/libpq.h:21,
 from printtup.c:20:
../../../../src/include/libpq/pqcomm.h:54: parse error before sa_family_t
../../../../src/include/libpq/pqcomm.h:54: warning: no semicolon at end 
of struc
t or union
../../../../src/include/libpq/pqcomm.h:56: `sa_family_t' undeclared here 
(not in
 a function)
../../../../src/include/libpq/pqcomm.h:63: `sa_family_t' undeclared here 
(not in
 a function)
../../../../src/include/libpq/pqcomm.h:63: `sa_family_t' undeclared here 
(not in
 a function)
../../../../src/include/libpq/pqcomm.h:67: parse error before '}' token
../../../../src/include/libpq/pqcomm.h:77: field `addr' has incomplete type
../../../../src/include/libpq/pqcomm.h:79: confused by earlier errors, 
bailing o
ut
make[4]: *** [printtup.o] Error 1



---(end of broadcast)---
TIP 8: explain analyze is your friend

Re: [HACKERS] sa_family_t in cygwin compile of cvs + regression failure

2003-06-23 Thread Bruce Momjian 
deststar wrote:
 I still seem to get a compile problem (included below).
 Will double check tomorrow when not so tired (02:15 here).
 Cheers,
 - Stuart
 P.S. My server seems to be blacklisted as a spam server by you. Please 
 could you white list me.
 
 gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations 
 -I../../../../src/i
 nclude  -DBUILDING_DLL  -c -o printtup.o printtup.c -MMD
 In file included from ../../../../src/include/libpq/libpq-be.h:22,
   from ../../../../src/include/libpq/libpq.h:21,
   from printtup.c:20:
 ../../../../src/include/libpq/pqcomm.h:54: parse error before sa_family_t
 ../../../../src/include/libpq/pqcomm.h:54: warning: no semicolon at end 
 of struc
 t or union
 ../../../../src/include/libpq/pqcomm.h:56: `sa_family_t' undeclared here 
 (not in
   a function)
 ../../../../src/include/libpq/pqcomm.h:63: `sa_family_t' undeclared here 
 (not in
   a function)
 ../../../../src/include/libpq/pqcomm.h:63: `sa_family_t' undeclared here 
 (not in
   a function)
 ../../../../src/include/libpq/pqcomm.h:67: parse error before '}' token
 ../../../../src/include/libpq/pqcomm.h:77: field `addr' has incomplete type
 ../../../../src/include/libpq/pqcomm.h:79: confused by earlier errors, 
 bailing o
 ut
 make[4]: *** [printtup.o] Error 1
 
 
 
 ---(end of broadcast)---
 TIP 8: explain analyze is your friend
 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073
Index: src/include/libpq/pqcomm.h
===
RCS file: /cvsroot/pgsql-server/src/include/libpq/pqcomm.h,v
retrieving revision 1.87
diff -c -c -r1.87 pqcomm.h
*** src/include/libpq/pqcomm.h  23 Jun 2003 23:51:59 -  1.87
--- src/include/libpq/pqcomm.h  24 Jun 2003 01:48:40 -
***
*** 47,52 
--- 47,56 
  #define   _SS_PAD2SIZE(_SS_MAXSIZE - (sizeof (sa_family_t) + \
_SS_PAD1SIZE + _SS_ALIGNSIZE))
  
+ #ifdef __CYGWIN__
+ typedef unsigned short sa_family_t;
+ #endif
+ 
  struct sockaddr_storage {
  #ifdef SALEN
  uint8_t   __ss_len;/* address length */

---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]

Re: [HACKERS] sa_family_t in cygwin compile of cvs + regression failure

2003-06-23 Thread Bruce Momjian 

OK, patch applied to typedef sa_family_t for cygwin.  If other platforms
need it, I will have to do something more generic.

Thanks for the testing.  Block removed, though I did have that ISP
marked as cronic, so there must have been a bunch of spam from there,
not just a few.

---

deststar wrote:
 I still seem to get a compile problem (included below).
 Will double check tomorrow when not so tired (02:15 here).
 Cheers,
 - Stuart
 P.S. My server seems to be blacklisted as a spam server by you. Please 
 could you white list me.
 
 gcc -O2 -g -Wall -Wmissing-prototypes -Wmissing-declarations 
 -I../../../../src/i
 nclude  -DBUILDING_DLL  -c -o printtup.o printtup.c -MMD
 In file included from ../../../../src/include/libpq/libpq-be.h:22,
   from ../../../../src/include/libpq/libpq.h:21,
   from printtup.c:20:
 ../../../../src/include/libpq/pqcomm.h:54: parse error before sa_family_t
 ../../../../src/include/libpq/pqcomm.h:54: warning: no semicolon at end 
 of struc
 t or union
 ../../../../src/include/libpq/pqcomm.h:56: `sa_family_t' undeclared here 
 (not in
   a function)
 ../../../../src/include/libpq/pqcomm.h:63: `sa_family_t' undeclared here 
 (not in
   a function)
 ../../../../src/include/libpq/pqcomm.h:63: `sa_family_t' undeclared here 
 (not in
   a function)
 ../../../../src/include/libpq/pqcomm.h:67: parse error before '}' token
 ../../../../src/include/libpq/pqcomm.h:77: field `addr' has incomplete type
 ../../../../src/include/libpq/pqcomm.h:79: confused by earlier errors, 
 bailing o
 ut
 make[4]: *** [printtup.o] Error 1
 
 
 
 ---(end of broadcast)---
 TIP 8: explain analyze is your friend
 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073
Index: src/include/libpq/pqcomm.h
===
RCS file: /cvsroot/pgsql-server/src/include/libpq/pqcomm.h,v
retrieving revision 1.87
diff -c -c -r1.87 pqcomm.h
*** src/include/libpq/pqcomm.h  23 Jun 2003 23:51:59 -  1.87
--- src/include/libpq/pqcomm.h  24 Jun 2003 01:48:40 -
***
*** 47,52 
--- 47,56 
  #define   _SS_PAD2SIZE(_SS_MAXSIZE - (sizeof (sa_family_t) + \
_SS_PAD1SIZE + _SS_ALIGNSIZE))
  
+ #ifdef __CYGWIN__
+ typedef unsigned short sa_family_t;
+ #endif
+ 
  struct sockaddr_storage {
  #ifdef SALEN
  uint8_t   __ss_len;/* address length */

---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster

Re: [HACKERS] sa_family_t in cygwin compile of cvs + regression failure

2003-06-16 Thread Jason Tishler 
On Sun, Jun 15, 2003 at 04:54:21PM +0100, deststar wrote:
 On cygwin sa_family_t was undeclared, adding the following line:
 typedef unsigned short sa_family_t;
 to both:
 src/port/getaddrinfo.c
 src/include/libpq/pqcomm.h

Isn't the attached or fixing Cygwin itself a better approach?

 seemed to compile ok but with make check there was one regression 
 failure in test privileges (doesn't look realted, but I'm not sure).

I have also observed similar problems when I (used to) use make check
myself.  This test passes under make installcheck.

BTW, because of the above and the following (from the Cygwin PostgreSQL
README):

1. make check can generate spurious regression test failures due to
overflowing the the listen() backlog queue which generates
connection refused errors.  Note that make installcheck does not
have this problem since it runs all tests sequentially instead of in
large concurrent groups.

I no longer use make check even though make installcheck is much less
convenient.

 Also included for ease of testing is a patch sepratly sent to patches 
 for ecpg.

Thanks for the patch!

Jason

-- 
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D  8784 1AFD E4CC ECF4 8EF6
Index: src/include/port/cygwin.h
===
RCS file: /projects/cvsroot/pgsql-server/src/include/port/cygwin.h,v
retrieving revision 1.3
diff -u -p -r1.3 cygwin.h
--- src/include/port/cygwin.h   22 May 2003 17:20:28 -  1.3
+++ src/include/port/cygwin.h   16 Jun 2003 17:20:19 -
@@ -21,3 +21,5 @@ typedef unsigned char slock_t;
 #else
 #define DLLIMPORT __declspec (dllimport)
 #endif
+
+typedef unsigned short sa_family_t;

---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly

[HACKERS] sa_family_t in cygwin compile of cvs + regression failure

2003-06-15 Thread deststar 
On cygwin sa_family_t was undeclared, adding the following line:
typedef unsigned short sa_family_t;
to both:
src/port/getaddrinfo.c
src/include/libpq/pqcomm.h
seemed to compile ok but with make check there was one regression 
failure in test privileges (doesn't look realted, but I'm not sure).
Also included for ease of testing is a patch sepratly sent to patches 
for ecpg.
System: Athalon + Win 2k + cygwin 1.3.22 + gcc 3.2
*** ./expected/privileges.out   Wed May 14 04:26:04 2003
--- ./results/privileges.outSun Jun 15 16:12:34 2003
***
*** 10,18 
--- 10,22 
  CREATE GROUP regressgroup1;
  CREATE GROUP regressgroup2 WITH USER regressuser1, regressuser2;
  ALTER GROUP regressgroup1 ADD USER regressuser4;
+ WARNING:  AbortTransaction and not in in-progress state
+ ERROR:  rename 
/home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group.2284 
to /home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group: 
Permission denied
  ALTER GROUP regressgroup2 ADD USER regressuser2;  -- duplicate
  WARNING:  ALTER GROUP: user regressuser2 is already in group regressgroup2
  ALTER GROUP regressgroup2 DROP USER regressuser2;
+ WARNING:  AbortTransaction and not in in-progress state
+ ERROR:  rename 
/home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group.2284 
to /home/Administrator/pgcvs/pgsql/src/test/regress/./tmp_check/data/global/pg_group: 
Permission denied
  ALTER GROUP regressgroup2 ADD USER regressuser4;
  -- test owner privileges
  SET SESSION AUTHORIZATION regressuser1;

==

*** src/interfaces/ecpg/compatlib/Makefile.orig Thu May 22 18:20:44 2003
--- src/interfaces/ecpg/compatlib/Makefile  Sun Jun 15 15:45:34 2003
***
*** 17,23 
  SO_MINOR_VERSION= 0.0
  
  override CPPFLAGS := -I$(top_srcdir)/src/interfaces/ecpg/include 
-I$(top_srcdir)/src/include/utils $(CPPFLAGS)
! SHLIB_LINK = -L../pgtypeslib -lpgtypes
  
  OBJS= informix.o
  
--- 17,23 
  SO_MINOR_VERSION= 0.0
  
  override CPPFLAGS := -I$(top_srcdir)/src/interfaces/ecpg/include 
-I$(top_srcdir)/src/include/utils $(CPPFLAGS)
! SHLIB_LINK = -L../pgtypeslib -lpgtypes -L../ecpglib -lecpg
  
  OBJS= informix.o
  

---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send unregister YourEmailAddressHere to [EMAIL PROTECTED])