Re: [HACKERS] settings without unit

2014-10-13 Thread Bruce Momjian 
On Thu, Sep  4, 2014 at 08:50:36PM -0300, Euler Taveira wrote:
 Hi,
 
 I noticed that a setting in pg_settings without units have NULL and 
 as unit values ( for integer and NULL for the other ones). Could we be
 consistent? It is like that since units were introduced (b517e65). No
 unit means unit = NULL. A proposed patch is attached.

Thanks.  Patch applied.

-- 
  Bruce Momjian  br...@momjian.ushttp://momjian.us
  EnterpriseDB http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] settings without unit

2014-09-04 Thread Euler Taveira 
Hi,

I noticed that a setting in pg_settings without units have NULL and 
as unit values ( for integer and NULL for the other ones). Could we be
consistent? It is like that since units were introduced (b517e65). No
unit means unit = NULL. A proposed patch is attached.


-- 
   Euler Taveira   Timbira - http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento
*** guc.c.orig	2014-09-04 20:16:09.108040521 -0300
--- guc.c	2014-09-04 17:48:35.113897896 -0300
***
*** 7690,7696 
  values[2] = min;
  break;
  			default:
! values[2] = ;
  break;
  		}
  	}
--- 7690,7696 
  values[2] = min;
  break;
  			default:
! values[2] = NULL;
  break;
  		}
  	}

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers