Re: [HACKERS] visibilitymap_clear()s in vacuumlazy.c aren't WAL logged

2016-07-16 Thread Michael Paquier
On Sat, Jul 16, 2016 at 10:23 AM, Andres Freund  wrote:
> The $subject says it all. Am I missing something, or is that not ok?

Indeed, it would be a good thing to get those sanity checks logged so
as standbys get the call, or at least perform the sanity check as well
on the block that the system is warning about. It seems to me that
logging the VM bit would be an interesting option as well, bringing to
the fact that there should be dedicated WAL records.

(By the way, adding a check for the case where a page contains
non-frozen tuples but the VM has the all-frozen bit set would be good
as well)

> Now, these branches should never be hit, but it surely isn't good that
> the corruption will persist on a primary, after it's explicitly been
> fixed on the standby.

"primary" and "standby" are reversed here?
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] visibilitymap_clear()s in vacuumlazy.c aren't WAL logged

2016-07-15 Thread Andres Freund
Hi,

The $subject says it all. Am I missing something, or is that not ok?
Now, these branches should never be hit, but it surely isn't good that
the corruption will persist on a primary, after it's explicitly been
fixed on the standby.

Greetings,

Andres Freund


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers