Re: [HACKERS] what to do about unsupported encodings

2016-10-26 Thread Michael Paquier
On Thu, Oct 27, 2016 at 2:01 AM, Tom Lane wrote: > Slightly related: there are some callers such as PGLC_localeconv that > aren't checking for a failure return. Seems bad. And also related to the patch trying to improve OOM handling in pg_locale.c, the point being that

Re: [HACKERS] what to do about unsupported encodings

2016-10-26 Thread Tom Lane
Peter Eisentraut writes: > pg_get_encoding_from_locale() in chklocale.c reports this when it finds > a locale with an encoding it does not recognize: > ereport(WARNING, > (errmsg("could not determine encoding for locale \"%s\": codeset > is \"%s\"", >

[HACKERS] what to do about unsupported encodings

2016-10-26 Thread Peter Eisentraut
pg_get_encoding_from_locale() in chklocale.c reports this when it finds a locale with an encoding it does not recognize: ereport(WARNING, (errmsg("could not determine encoding for locale \"%s\": codeset is \"%s\"", ctype, sys), errdetail("Please report this to