Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Peter Eisentraut
On 6/13/13 5:47 PM, Josh Berkus wrote: 2. File name to store settings set by ALTER SYSTEM command is still persistent.auto.conf Why? Shouldn't it just be auto.conf? Or system.auto.conf? I prefer auto.conf, personally. Well, not much about it is automatic, really. It's just set

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Josh Berkus
On 06/19/2013 10:48 AM, Peter Eisentraut wrote: On 6/13/13 5:47 PM, Josh Berkus wrote: 2. File name to store settings set by ALTER SYSTEM command is still persistent.auto.conf Why? Shouldn't it just be auto.conf? Or system.auto.conf? I prefer auto.conf, personally. Well, not much about

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Peter Eisentraut
On 6/19/13 1:49 PM, Josh Berkus wrote: On 06/19/2013 10:48 AM, Peter Eisentraut wrote: On 6/13/13 5:47 PM, Josh Berkus wrote: 2. File name to store settings set by ALTER SYSTEM command is still persistent.auto.conf Why? Shouldn't it just be auto.conf? Or system.auto.conf? I prefer

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Magnus Hagander
On Jun 19, 2013 7:55 PM, Peter Eisentraut pete...@gmx.net wrote: On 6/19/13 1:49 PM, Josh Berkus wrote: On 06/19/2013 10:48 AM, Peter Eisentraut wrote: On 6/13/13 5:47 PM, Josh Berkus wrote: 2. File name to store settings set by ALTER SYSTEM command is still persistent.auto.conf Why?

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Alvaro Herrera
Magnus Hagander wrote: On Jun 19, 2013 7:55 PM, Peter Eisentraut pete...@gmx.net wrote: generated_by_server.conf System.conf? alter_system.conf ? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: True, but can you think of a better word to mean don't edit this by hand? The file name is not nearly as important for that as putting in a header comment # Don't edit this file by hand. regards, tom lane -- Sent via pgsql-hackers

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Amit Kapila
On Thursday, June 20, 2013 3:53 AM Tom Lane wrote: Josh Berkus j...@agliodbs.com writes: True, but can you think of a better word to mean don't edit this by hand? The file name is not nearly as important for that as putting in a header comment # Don't edit this file by hand. Currently

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Amit Kapila
On Thursday, June 20, 2013 12:32 AM Alvaro Herrera wrote: Magnus Hagander wrote: On Jun 19, 2013 7:55 PM, Peter Eisentraut pete...@gmx.net wrote: generated_by_server.conf System.conf? alter_system.conf ? All the names proposed in this thread are as follows: Auto.conf-

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-19 Thread Alvaro Herrera
Amit Kapila wrote: Currently header comment is: # Do not edit this file manually! # It will be overwritten by ALTER SYSTEM command. Kindly let me know your suggestion about the above comment in header? This seems perfect to me. -- Álvaro Herrera

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-18 Thread Boszormenyi Zoltan
Hi, review below. 2013-06-13 14:35 keltezéssel, Amit Kapila írta: On Friday, June 07, 2013 9:45 AM Amit Kapila wrote: On Thursday, June 06, 2013 10:22 PM Robert Haas wrote: On Wed, Jun 5, 2013 at 7:24 AM, Amit Kapila amit.kap...@huawei.com wrote: On Monday, May 27, 2013 4:17 PM Amit Kapila

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-18 Thread Boszormenyi Zoltan
2013-06-14 05:12 keltezéssel, Amit Kapila írta: On Friday, June 14, 2013 3:17 AM Josh Berkus wrote: On 06/13/2013 05:35 AM, Amit Kapila wrote: On Friday, June 07, 2013 9:45 AM Amit Kapila wrote: On Thursday, June 06, 2013 10:22 PM Robert Haas wrote: On Wed, Jun 5, 2013 at 7:24 AM, Amit

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-18 Thread Amit Kapila
On Tuesday, June 18, 2013 3:26 PM Boszormenyi Zoltan wrote: Hi, review below. Thanks for the review. There are 2 options to proceed for this patch for 9.4 1. Upload the SET PERSISTENT syntax patch for coming CF by fixing existing review comments 2. Implement new syntax ALTER SYSTEM as

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-18 Thread Boszormenyi Zoltan
2013-06-18 14:11 keltezéssel, Amit Kapila írta: On Tuesday, June 18, 2013 3:26 PM Boszormenyi Zoltan wrote: Hi, review below. Thanks for the review. There are 2 options to proceed for this patch for 9.4 1. Upload the SET PERSISTENT syntax patch for coming CF by fixing existing review

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-18 Thread Josh Berkus
Amit, I think, the decision of name, we can leave to committer with below possibilities, as it is very difficult to build consensus on any particular name. Auto.conf System.auto.conf Postgresql.auto.conf Persistent.auto.conf Reasons for auto.conf as a choice above all of the previous:

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-13 Thread Josh Berkus
On 06/13/2013 05:35 AM, Amit Kapila wrote: On Friday, June 07, 2013 9:45 AM Amit Kapila wrote: On Thursday, June 06, 2013 10:22 PM Robert Haas wrote: On Wed, Jun 5, 2013 at 7:24 AM, Amit Kapila amit.kap...@huawei.com wrote: On Monday, May 27, 2013 4:17 PM Amit Kapila wrote: On Wednesday,

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-06-13 Thread Amit Kapila
On Friday, June 14, 2013 3:17 AM Josh Berkus wrote: On 06/13/2013 05:35 AM, Amit Kapila wrote: On Friday, June 07, 2013 9:45 AM Amit Kapila wrote: On Thursday, June 06, 2013 10:22 PM Robert Haas wrote: On Wed, Jun 5, 2013 at 7:24 AM, Amit Kapila amit.kap...@huawei.com wrote: On Monday,

<    1   2   3