Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-27 Thread Peter Eisentraut
On tor, 2012-02-09 at 13:30 -0500, Tom Lane wrote: > > Also, we should at least do the attached to simplify the process. > > +check: > > + $(top_srcdir)/src/tools/check_keywords.pl $(top_srcdir) > > Actually, what would make sense in that line is to attach it to the > existing maintainer-check

Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-12 Thread Heikki Linnakangas
On 11.02.2012 11:57, Alex Hunsaker wrote: On Thu, Feb 9, 2012 at 11:30, Tom Lane wrote: Alvaro Herrera writes: Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012: FWIW that script is throwing a warning here: Use of assignment to $[ is deprecated at /pgsql/source/HEAD/src/t

Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-11 Thread Alex Hunsaker
On Thu, Feb 9, 2012 at 11:30, Tom Lane wrote: > Alvaro Herrera writes: >> Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012: >> FWIW that script is throwing a warning here: >> Use of assignment to $[ is deprecated at >> /pgsql/source/HEAD/src/tools/check_keywords.pl line 19. >

Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012: >> If people are sufficiently worried about this, a better answer would be >> to teach the makefiles to run check_keywords.pl during every build. > FWIW that script is throwing a warning here: > Use of as

Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Alvaro Herrera
Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012: > > Alvaro Herrera writes: > > Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 > > 2012: > >> src/tools/check_keywords.pl is your friend. > > > I wondered a couple of weeks ago if we could, instead, gene

Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 2012: >> src/tools/check_keywords.pl is your friend. > I wondered a couple of weeks ago if we could, instead, generate the > lists in gram.y from kwlist.h. We've looked into that in the past. bison

Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Alvaro Herrera
Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 2012: > Add new keywords SNAPSHOT and TYPES to the keyword list in gram.y > > These were added to kwlist.h as unreserved keywords in separate patches, > but authors forgot to add them to the corresponding list in gram.y. > Be