Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-06 Thread Simon Riggs
On 6 April 2017 at 17:41, David Rowley wrote: > On 7 April 2017 at 00:47, Simon Riggs wrote: >> On 5 April 2017 at 18:48, Tom Lane wrote: >>> Simon Riggs writes: Collect and use multi-column dependency stats >>> >>> The buildfarm is unhappy about the fact that this changed the API >>> for

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-06 Thread David Rowley
On 7 April 2017 at 00:47, Simon Riggs wrote: > On 5 April 2017 at 18:48, Tom Lane wrote: >> Simon Riggs writes: >>> Collect and use multi-column dependency stats >> >> The buildfarm is unhappy about the fact that this changed the API >> for clauselist_selectivity(). I am not convinced that that

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-06 Thread Simon Riggs
On 5 April 2017 at 18:48, Tom Lane wrote: > Simon Riggs writes: >> Collect and use multi-column dependency stats > > The buildfarm is unhappy about the fact that this changed the API > for clauselist_selectivity(). I am not convinced that that change > was a good idea, so before telling FDW auth

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-06 Thread Kyotaro HORIGUCHI
At Thu, 6 Apr 2017 21:55:43 +1200, David Rowley wrote in > On 6 April 2017 at 19:50, Kyotaro HORIGUCHI > wrote: > > At Thu, 6 Apr 2017 18:59:35 +1200, David Rowley > > wrote in > > > >> On 6 April 2017 at 18:03, Kyotaro HORIGUCHI > >> wrote: > >> > At Thu, 6 Apr 2017 13:10:48 +1200, David

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-06 Thread David Rowley
On 6 April 2017 at 19:50, Kyotaro HORIGUCHI wrote: > At Thu, 6 Apr 2017 18:59:35 +1200, David Rowley > wrote in > >> On 6 April 2017 at 18:03, Kyotaro HORIGUCHI >> wrote: >> > At Thu, 6 Apr 2017 13:10:48 +1200, David Rowley >> > wrote in >> > >> >> On 6 April 2017 at 13:05, David Rowley

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-06 Thread Kyotaro HORIGUCHI
At Thu, 6 Apr 2017 18:59:35 +1200, David Rowley wrote in > On 6 April 2017 at 18:03, Kyotaro HORIGUCHI > wrote: > > At Thu, 6 Apr 2017 13:10:48 +1200, David Rowley > > wrote in > > > >> On 6 April 2017 at 13:05, David Rowley > >> wrote: > I'm not all that sure why the number of columns in

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-06 Thread David Rowley
On 6 April 2017 at 18:03, Kyotaro HORIGUCHI wrote: > At Thu, 6 Apr 2017 13:10:48 +1200, David Rowley > wrote in > >> On 6 April 2017 at 13:05, David Rowley wrote: >> > I tested with the attached, and it does not seem to hurt planner >> > performance executing: >> >> Here's it again, this time

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread Kyotaro HORIGUCHI
At Thu, 6 Apr 2017 13:10:48 +1200, David Rowley wrote in > On 6 April 2017 at 13:05, David Rowley wrote: > > I tested with the attached, and it does not seem to hurt planner > > performance executing: > > Here's it again, this time with a comment on the > find_relation_from_clauses() function.

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread David Rowley
On 6 April 2017 at 13:05, David Rowley wrote: > I tested with the attached, and it does not seem to hurt planner > performance executing: Here's it again, this time with a comment on the find_relation_from_clauses() function. -- David Rowley http://www.2ndQuadrant.com/ Postg

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread David Rowley
On 6 April 2017 at 11:33, Tom Lane wrote: > David Rowley writes: >> On 6 April 2017 at 10:48, Tom Lane wrote: >>> The buildfarm is unhappy about the fact that this changed the API >>> for clauselist_selectivity(). I am not convinced that that change >>> was a good idea, so before telling FDW au

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread Tom Lane
David Rowley writes: > On 6 April 2017 at 10:48, Tom Lane wrote: >> The buildfarm is unhappy about the fact that this changed the API >> for clauselist_selectivity(). I am not convinced that that change >> was a good idea, so before telling FDW authors that they need to >> change their code, I'd

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread David Rowley
On 6 April 2017 at 10:48, Tom Lane wrote: > Simon Riggs writes: >> Collect and use multi-column dependency stats > > The buildfarm is unhappy about the fact that this changed the API > for clauselist_selectivity(). I am not convinced that that change > was a good idea, so before telling FDW auth

Re: [HACKERS] [COMMITTERS] pgsql: Collect and use multi-column dependency stats

2017-04-05 Thread Tom Lane
Simon Riggs writes: > Collect and use multi-column dependency stats The buildfarm is unhappy about the fact that this changed the API for clauselist_selectivity(). I am not convinced that that change was a good idea, so before telling FDW authors that they need to change their code, I'd like to