On 05 April 2014 04:14, Tom Lane
> > [ pgctl_win32service_rel_dbpath_v6.patch ]
>
> Committed with minor corrections, mostly but not all cosmetic.
Thanks a lot...
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.
Rajeev rastogi writes:
> [ pgctl_win32service_rel_dbpath_v6.patch ]
Committed with minor corrections, mostly but not all cosmetic.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.p
Magnus Hagander
> Subject: Re: [HACKERS] [review] PostgreSQL Service on Windows does not
> start if data directory given is relative path
>
> From: "Rajeev rastogi" Please find the
> attached modified patch.
>
> Thanks, reviewed and made this patch ready for commit
From: "Rajeev rastogi"
Please find the attached modified patch.
Thanks, reviewed and made this patch ready for committer.
Regards
MauMau
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hacker
On 22 February 2014 06:16, MauMau Wrote:
Thanks for reviewing again.
> Please make small cosmetic changes so that make_absolute_path() follows
> the
> style of other parts. Then I'll make this ready for committer.
>
> (1)
> Add the function name in the comment as in:
>
> /*
> * make_absolute_
Hi Rajeev,
From: "Rajeev rastogi"
Changed the patch as per your suggestion.
Now only one version of make_absolute_path there defined in src/port/path.c
Found one small memory leak in the existing function
make_absolute_path(miscinit.c),
fixed the same.
Thanks for refactoring. I confirmed t
On 18 February 2014 21:47, MauMau Wrote:
> > We already have two different versions of make_absolute_path() in the
> > tree
> > - one in src/backend/utils/init/miscinit.c and one in
> > src/test/regress/pg_regress.c.
> >
> > I don't think we need a third one.
> >
> > If we put it in port/ like t
From: "Magnus Hagander"
We already have two different versions of make_absolute_path() in the tree
- one in src/backend/utils/init/miscinit.c and one in
src/test/regress/pg_regress.c.
I don't think we need a third one.
If we put it in port/ like this patch done, then we should make the other
c
On Mon, Feb 3, 2014 at 3:06 PM, MauMau wrote:
> From: "Rajeev rastogi"
>
> I will update commitFest with the latest patch immediately after sending
>> the mail.
>>
>
> OK, done setting the status to ready for committer.
>
>
We already have two different versions of make_absolute_path() in the t
From: "Rajeev rastogi"
I will update commitFest with the latest patch immediately after sending
the mail.
OK, done setting the status to ready for committer.
Regards
MauMau
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://ww
From: "Rajeev rastogi"
Please find the attached revised patch.
Thanks, your patch looks good. I confirmed the following:
* Applied cleanly to the latest source tree, and built on Linux and Windows
(with MSVC) without any warnings.
* Changed to D:\ and ran "pg_ctl register -N pg -D pgdata"
11 matches
Mail list logo