Re: [HACKERS] Can we amend gitignore so git postgresql works with git on windows using Msys/Mingw64

2016-03-26 Thread Regina Obe 

> You can change the setting with:
> git config --global core.autocrlf input

> Still, it's fair to wonder if we shouldn't add an entry for this to our
.gitattributes.  I'm actually wondering why we wouldn't apply it to ALL text
files in git, not just the extensions Regina mentioned.

> regards, tom lane

David,

Thanks for the tip.  I'll give that a try.  Still I think it's safer to use
.gitattributes.

to Tom's comment,
Here is why.  For certain repos, certain files are designated for certain
OS.  So you don't want your developer committer's settings controlling the
output.

Take for example windows specific files.  I do have lines like

*.vcprojeol=crlf
*.bat   eol=crlf


I don't actually think it much matters even for those if they have LF,
except for batch scripts it looks a bit wonky in some windows editors if
they don't have CRLF breaks.


I'm also not clear what Mac does.  Does Mac still do CR (instead of LF, I
thought it used to).  Does that mean if they switch their ending I'd
suddenly be getting Mac endings?

https://help.github.com/articles/dealing-with-line-endings/

As that above links says - "This file is committed into the repository and
overrides an individual's core.autocrlf setting, ensuring consistent
behavior for all users, regardless of their Git settings." 

I think consistency is more important in this case.


Thanks,
Regina






-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Can we amend gitignore so git postgresql works with git on windows using Msys/Mingw64

2016-03-26 Thread Tom Lane 
David Rowley  writes:
> On 26 March 2016 at 09:26, Regina Obe  wrote:
>> The problem is I can't compile from git postgresql, and the issue is I think
>> because my git when it pulls down the files they come in as CRLF which gets
>> all screwed up when compiling under msys/ mingw64.

> You can change the setting with:
> git config --global core.autocrlf input

Still, it's fair to wonder if we shouldn't add an entry for this to our
.gitattributes.  I'm actually wondering why we wouldn't apply it to ALL
text files in git, not just the extensions Regina mentioned.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Can we amend gitignore so git postgresql works with git on windows using Msys/Mingw64

2016-03-26 Thread David Rowley 
On 26 March 2016 at 09:26, Regina Obe  wrote:
> The problem is I can't compile from git postgresql, and the issue is I think
> because my git when it pulls down the files they come in as CRLF which gets
> all screwed up when compiling under msys/ mingw64.
> So I end up with non-sense messages like this:

Sounds like git is setup to convert the line endings to CRLF.

Check:
git config --list | grep crlf

Likely this will be set to "true"

You can change the setting with:
git config --global core.autocrlf input

drop the --global if you only want to change the current repo.

-- 
 David Rowley   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers