Re: [HACKERS] Fwd: [GENERAL] pgxs/config/missing is... missing

2015-12-11 Thread Jim Nasby
On 12/11/15 6:25 PM, Jim Nasby wrote: On 12/10/15 7:09 PM, Tom Lane wrote: Jim Nasby writes: AFAICT the problem is that missing wasn't included in install or uninstall in config/Makefile. Attached patch fixes that, and results in missing being properly installed in

Re: [HACKERS] Fwd: [GENERAL] pgxs/config/missing is... missing

2015-12-11 Thread Tom Lane
Jim Nasby writes: > Grr, right after sending this I found the thread you were talking about. > I'm not really sure our missing is better than just letting the error > bubble up. If folks think that's better then lets just rip missing out > entirely. Well, that's what

Re: [HACKERS] Fwd: [GENERAL] pgxs/config/missing is... missing

2015-12-11 Thread Jim Nasby
On 12/10/15 7:09 PM, Tom Lane wrote: Jim Nasby writes: AFAICT the problem is that missing wasn't included in install or uninstall in config/Makefile. Attached patch fixes that, and results in missing being properly installed in lib/pgxs/config. I thought we'd more

Re: [HACKERS] Fwd: [GENERAL] pgxs/config/missing is... missing

2015-12-10 Thread Tom Lane
Jim Nasby writes: > AFAICT the problem is that missing wasn't included in install or > uninstall in config/Makefile. Attached patch fixes that, and results in > missing being properly installed in lib/pgxs/config. I thought we'd more or less rejected that approach in