Re: [HACKERS] Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)

2015-02-21 Thread Jeff Davis
On Sun, 2015-02-22 at 00:07 -0500, Tom Lane wrote:
 If you want to have just *one* variable but change its name and type,
 I'd be ok with that.

Thank you for taking a quick look. Committed as a simple rename from
context to set.

Regards,
Jeff Davis




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)

2015-02-21 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes:
 This is just to make the variable names in this function consistent with
 the rest of the file (and less confusing). No functional impact, so I'll
 commit soon unless someone objects.

If I'm reading this right, this creates two different variables pointing
at the same object.  That does not sound like an improvement from a
readability standpoint.

If you want to have just *one* variable but change its name and type,
I'd be ok with that.

regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers