Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-04-19 Thread Bruce Momjian
On Wed, Apr 16, 2014 at 11:01:56PM -0400, Bruce Momjian wrote: > On Tue, Apr 1, 2014 at 10:32:01AM -0400, Tom Lane wrote: > > Adrian Vondendriesch writes: > > > I patched the function conninfo_array_parse() which is used by > > > PQconnectStartParams to behave like PQsetdbLogin. The patch also >

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-04-16 Thread Bruce Momjian
On Tue, Apr 1, 2014 at 10:32:01AM -0400, Tom Lane wrote: > Adrian Vondendriesch writes: > > I patched the function conninfo_array_parse() which is used by > > PQconnectStartParams to behave like PQsetdbLogin. The patch also > > contains a document patch which clarify "unspecified" parameters. >

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-04-16 Thread Bruce Momjian
On Tue, Apr 1, 2014 at 05:06:08PM +0200, Adrian Vondendriesch wrote: > Am 01.04.2014 16:32, schrieb Tom Lane: > > Adrian Vondendriesch writes: > >> I patched the function conninfo_array_parse() which is used by > >> PQconnectStartParams to behave like PQsetdbLogin. The patch also > >> contains a

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-04-01 Thread Adrian Vondendriesch
Am 01.04.2014 16:32, schrieb Tom Lane: > Adrian Vondendriesch writes: >> I patched the function conninfo_array_parse() which is used by >> PQconnectStartParams to behave like PQsetdbLogin. The patch also >> contains a document patch which clarify "unspecified" parameters. > > I see no documentat

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-04-01 Thread Tom Lane
Adrian Vondendriesch writes: > I patched the function conninfo_array_parse() which is used by > PQconnectStartParams to behave like PQsetdbLogin. The patch also > contains a document patch which clarify "unspecified" parameters. I see no documentation update here. I'm also fairly concerned abou

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-04-01 Thread Adrian Vondendriesch
Hi, Am Wed, 12 Feb 2014 13:47:41 -0500 schrieb Robert Haas : > On Mon, Feb 10, 2014 at 12:14 PM, Jeff Janes > wrote: > >> Presumably whatever behavior difference you are seeing is somehow > >> related to the use of PQconnectdbParams() rather than > >> PQsetdbLogin(), but the fine manual does not

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-02-12 Thread Robert Haas
On Mon, Feb 10, 2014 at 12:14 PM, Jeff Janes wrote: >> Presumably whatever behavior difference you are seeing is somehow >> related to the use of PQconnectdbParams() rather than PQsetdbLogin(), >> but the fine manual does not appear to document a different between >> those functions as regards pas

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-02-10 Thread Jeff Janes
On Sun, Feb 9, 2014 at 4:56 PM, Robert Haas wrote: > On Sun, Feb 9, 2014 at 6:33 PM, Jeff Janes wrote: > > > > Since this commit (17676c785a95b2598c573), pgbench no longer uses > .pgpass to > > obtain passwords, but instead prompts for a password > > > > This problem is in 9.3 and 9.4dev > > > >

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-02-09 Thread Robert Haas
On Sun, Feb 9, 2014 at 6:33 PM, Jeff Janes wrote: > On Wed, Jul 4, 2012 at 12:41 PM, Robert Haas wrote: >> On Tue, Jul 3, 2012 at 11:36 PM, Amit Kapila >> wrote: >> > Hi Shigeru/Robert, >> > >> >> The way fixing oid2name and pgbench seems reasonable, so applying it to >> >> vacuumlo (as Peter me

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-02-09 Thread Jeff Janes
On Wed, Jul 4, 2012 at 12:41 PM, Robert Haas wrote: > On Tue, Jul 3, 2012 at 11:36 PM, Amit Kapila > wrote: > > Hi Shigeru/Robert, > > > >> The way fixing oid2name and pgbench seems reasonable, so applying it to > >> vacuumlo (as Peter mentioned) would be enough for this issue. > > > > Shall I c

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-04 Thread Robert Haas
On Tue, Jul 3, 2012 at 11:36 PM, Amit Kapila wrote: > Hi Shigeru/Robert, > >> The way fixing oid2name and pgbench seems reasonable, so applying it to >> vacuumlo (as Peter mentioned) would be enough for this issue. > > Shall I consider following 2 points to update the patch: > 1. Apply changes sim

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-03 Thread Amit Kapila
Hi Shigeru/Robert, -Original Message- From: Shigeru HANADA [mailto:shigeru.han...@gmail.com] Sent: Wednesday, July 04, 2012 6:57 AM (2012/06/28 11:16), Robert Haas wrote: >> If it can be done without costing anything meaningful, I don't object, >> but I would humbly suggest that this is

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-03 Thread Shigeru HANADA
(2012/06/28 11:16), Robert Haas wrote: > If it can be done without costing anything meaningful, I don't object, > but I would humbly suggest that this is not hugely important one way > or the other. application_name is primarily a monitoring convenience, > so it's not hugely important to have it s

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-07-03 Thread Peter Eisentraut
On fre, 2012-06-08 at 17:14 +, Amit kapila wrote: > This patch is to provide support for fallback application name for > contrib/pgbench, oid2name, and dblink. vacuumlo should also be treated, I think. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-27 Thread Amit Kapila
From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Thursday, June 28, 2012 7:46 AM On Wed, Jun 27, 2012 at 9:57 PM, Shigeru HANADA wrote: > On Thu, Jun 14, 2012 at 10:55 PM, Robert Haas wrote: >> Indeed reparsing connection string is not cheap, but dblink does it for >> checking password req

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-27 Thread Robert Haas
On Wed, Jun 27, 2012 at 9:57 PM, Shigeru HANADA wrote: > On Thu, Jun 14, 2012 at 10:55 PM, Robert Haas wrote: >> On Wed, Jun 13, 2012 at 12:07 AM, Amit Kapila wrote: >>> To achieve the same in dblink, we need to parse the passed connection string >>> and check if it contains fallback_application

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-27 Thread Shigeru HANADA
On Thu, Jun 14, 2012 at 10:55 PM, Robert Haas wrote: > On Wed, Jun 13, 2012 at 12:07 AM, Amit Kapila wrote: >> To achieve the same in dblink, we need to parse the passed connection string >> and check if it contains fallback_application_name, if yes then its okay, >> otherwise we need to append f

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-14 Thread Amit Kapila
Subject: Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink On Wed, Jun 13, 2012 at 12:07 AM, Amit Kapila wrote: > >> Why not 'dblink'? > > We can do for dblink as well. I just wanted to check before implemen

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-14 Thread Robert Haas
On Wed, Jun 13, 2012 at 12:07 AM, Amit Kapila wrote: > >> Why not 'dblink'? > > We can do for dblink as well. I just wanted to check before implementing in > dblink. > > I have checked the dblink_connect() function, it receives the connect string > and used in most cases that string to > call libp

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-13 Thread Amit Kapila
: Wednesday, June 13, 2012 12:13 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink On Mon, Jun 11, 2012 at 5:30 AM, Amit Kapila wrote: > As per the previous discussion in l

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-12 Thread Amit Kapila
f any of this option is okay or what is other way to get the program name. -Original Message- From: Robert Haas [mailto:robertmh...@gmail.com] Sent: Wednesday, June 13, 2012 12:13 AM To: Amit Kapila Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] WIP patch for Todo I

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-12 Thread Robert Haas
On Mon, Jun 11, 2012 at 5:30 AM, Amit Kapila wrote: > As per the previous discussion in link below, it seems that fallback > application name needs to be provided for only > > pgbench and oid2name. > > http://archives.postgresql.org/message-id/w2g9837222c1004070216u3bc46b3ahbddfdffdbfb46...@mail.g

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2012-06-11 Thread Amit Kapila
As per the previous discussion in link below, it seems that fallback application name needs to be provided for only pgbench and oid2name. http://archives.postgresql.org/message-id/w2g9837222c1004070216u3bc46b3ahbdd fdffdbfb46...@mail.gmail.com However the title of Todo Item suggests it needs