On Tue, Feb 16, 2016 at 8:47 AM, Alvaro Herrera
wrote:
> Michael Paquier wrote:
>
>> Different issues in the same area:
>> 1) In vacuumdb.c, init_slot() does not check for the return value of
>> PQsocket():
>> slot->sock = PQsocket(conn);
>> 2) In isolationtester.c, try_complete_step() should do
I noticed that strerror(errno) wasn't the most helpful error context
ever, so I changed it to PQerrorMessage(). There may be room for
additional improvement there.
I also noticed that if one connection dies, we terminate the whole
thread, and if the thread is serving multiple connections, the oth
Hello Alvaro,
Any objections to changing it like this? I'd probably backpatch to 9.5,
but no further (even though this pattern actually appears all the way
back.)
My 0.02€: if the pattern is repeated, maybe a function which incorporates
the check would save lines and improve overall readabi
On Mon, Feb 15, 2016 at 3:20 PM, Michael Paquier
wrote:
> On Sat, Feb 13, 2016 at 6:25 AM, Alvaro Herrera
> wrote:
>> I noticed that pgbench calls FD_ISSET on a socket returned by
>> PQsocket() without first checking that it's not invalid. I don't think
>> there's a real problem here because th
On Sat, Feb 13, 2016 at 6:25 AM, Alvaro Herrera wrote:
> I noticed that pgbench calls FD_ISSET on a socket returned by
> PQsocket() without first checking that it's not invalid. I don't think
> there's a real problem here because the socket was already checked a few
> lines above, but I think app
