Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-19 Thread Peter Eisentraut
On tis, 2011-10-18 at 21:47 -0700, Jeff Davis wrote: On Tue, 2011-10-18 at 22:25 +0300, Peter Eisentraut wrote: Presumably because Jeff doesn't have that particular locale installed. locale -a would clarify that. $ locale -a |grep -i tr tr_CY.utf8 tr_TR.utf8 So, yes, I only have the

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-19 Thread Peter Eisentraut
On ons, 2011-10-19 at 01:10 -0400, Tom Lane wrote: Jeff Davis pg...@j-davis.com writes: On Tue, 2011-10-18 at 22:25 +0300, Peter Eisentraut wrote: Presumably because Jeff doesn't have that particular locale installed. locale -a would clarify that. $ locale -a |grep -i tr tr_CY.utf8

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-19 Thread Jeff Davis
On Wed, 2011-10-19 at 11:44 +0300, Peter Eisentraut wrote: On tis, 2011-10-18 at 21:47 -0700, Jeff Davis wrote: On Tue, 2011-10-18 at 22:25 +0300, Peter Eisentraut wrote: Presumably because Jeff doesn't have that particular locale installed. locale -a would clarify that. $ locale -a

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-19 Thread Jeff Davis
On Wed, 2011-10-19 at 10:10 -0700, Jeff Davis wrote: dpkg-reconfigure locales I had to manually do # locale-gen tr_TR to make it generate tr_TR.ISO-8859-9, and now it works. I'm not sure what we should do, exactly, but I expect that others who attempt to run the test on ubuntu (and maybe

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-18 Thread Jeff Davis
On Sun, 2011-10-16 at 16:00 -0400, Tom Lane wrote: Jeff Davis pg...@j-davis.com writes: On master, I see a minor test error (at least on my machine) as well as a diff. Patch attached. Hmm, yeah, I forgot to fix this regression test when I added that DETAIL line. However, I don't see the

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-18 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: On Sun, 2011-10-16 at 16:00 -0400, Tom Lane wrote: Hmm, yeah, I forgot to fix this regression test when I added that DETAIL line. However, I don't see the need for fooling with the lc_time value? Here is the diff that I'm seeing on master right now with:

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-18 Thread Peter Eisentraut
On tis, 2011-10-18 at 01:07 -0700, Jeff Davis wrote: On Sun, 2011-10-16 at 16:00 -0400, Tom Lane wrote: Jeff Davis pg...@j-davis.com writes: On master, I see a minor test error (at least on my machine) as well as a diff. Patch attached. Hmm, yeah, I forgot to fix this regression test

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-18 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On tis, 2011-10-18 at 01:07 -0700, Jeff Davis wrote: If I qualify it as tr_TR.UTF-8 it works. Perhaps I have something misconfigured on my system (Ubuntu 11.10)? I just installed: language-pack-de language-pack-tr language-pack-sv in an attempt to

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-18 Thread Peter Eisentraut
On tis, 2011-10-18 at 15:21 -0400, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: On tis, 2011-10-18 at 01:07 -0700, Jeff Davis wrote: If I qualify it as tr_TR.UTF-8 it works. Perhaps I have something misconfigured on my system (Ubuntu 11.10)? I just installed: language-pack-de

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-18 Thread Jeff Davis
On Tue, 2011-10-18 at 22:25 +0300, Peter Eisentraut wrote: Presumably because Jeff doesn't have that particular locale installed. locale -a would clarify that. $ locale -a |grep -i tr tr_CY.utf8 tr_TR.utf8 So, yes, I only have the UTF8 version. I didn't realize they were different -- do you

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-18 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: On Tue, 2011-10-18 at 22:25 +0300, Peter Eisentraut wrote: Presumably because Jeff doesn't have that particular locale installed. locale -a would clarify that. $ locale -a |grep -i tr tr_CY.utf8 tr_TR.utf8 So, yes, I only have the UTF8 version. Wow,

[HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-16 Thread Jeff Davis
On master, I see a minor test error (at least on my machine) as well as a diff. Patch attached. Regards, Jeff Davis *** a/src/test/regress/expected/collate.linux.utf8.out --- b/src/test/regress/expected/collate.linux.utf8.out *** *** 395,401 SELECT relname FROM pg_class

Re: [HACKERS] (patch) regression diffs on collate.linux.utf8 test

2011-10-16 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: On master, I see a minor test error (at least on my machine) as well as a diff. Patch attached. Hmm, yeah, I forgot to fix this regression test when I added that DETAIL line. However, I don't see the need for fooling with the lc_time value?