Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-11 Thread Tom Lane
Michael Paquier writes: > On Sun, Jul 10, 2016 at 11:52 PM, Tom Lane wrote: >> Yes, please --- I thought it'd all gotten done. > OK, here are patches for 9.1, 9.2 and 9.3. Pushed, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgre

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-10 Thread Michael Paquier
On Sun, Jul 10, 2016 at 11:52 PM, Tom Lane wrote: > Michael Paquier writes: >> Thanks! What you have pushed looks fine to me. Also, the portion for >> src/tools/msvc needs to go further down, I should have precised that >> earlier. Do you want a patch for that? > > Yes, please --- I thought it'd

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-10 Thread Tom Lane
Michael Paquier writes: > Thanks! What you have pushed looks fine to me. Also, the portion for > src/tools/msvc needs to go further down, I should have precised that > earlier. Do you want a patch for that? Yes, please --- I thought it'd all gotten done. regards, tom lane

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-10 Thread Michael Paquier
On Sun, Jul 10, 2016 at 5:50 AM, Tom Lane wrote: > This seemed like a bug fix to me ... Yes, it is. > ... so I went ahead and pushed it. I don't > have any ability to test the Windows parts, so it's possible I missed > something in the back-patching; please review. Thanks! What you have pushed

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-09 Thread Tom Lane
Kyotaro HORIGUCHI writes: > At Tue, 5 Jul 2016 13:44:08 +0900, Michael Paquier > wrote in > >> Attached is the patch I have in mind. After more investigation zic.exe >> is indeed broken, $target can be a full path, and if it contains a >> space things blow up. The commands of vcregress upgrade

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-05 Thread Michael Paquier
On Tue, Jul 5, 2016 at 6:02 PM, Kyotaro HORIGUCHI wrote: > Agreed. Grep'ing "system" in the source tree, I see no more place > where needs the same fix. Same conclusion here. I have added this stuff to the official patch tracker: https://commitfest.postgresql.org/10/663/ I can as well produce pat

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-05 Thread Kyotaro HORIGUCHI
Hello, At Tue, 5 Jul 2016 13:44:08 +0900, Michael Paquier wrote in > On Mon, Jul 4, 2016 at 4:44 PM, Michael Paquier > wrote: > > And as is the command built for zic.exe in Install.pm, no? $target is > > normally an absolute path per the call of Install(). > > Attached is the patch I have in

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-04 Thread Michael Paquier
On Mon, Jul 4, 2016 at 4:44 PM, Michael Paquier wrote: > And as is the command built for zic.exe in Install.pm, no? $target is > normally an absolute path per the call of Install(). Attached is the patch I have in mind. After more investigation zic.exe is indeed broken, $target can be a full path

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-04 Thread Michael Paquier
On Mon, Jul 4, 2016 at 4:29 PM, Michael Paquier wrote: > On Mon, Jul 4, 2016 at 4:02 PM, Kyotaro HORIGUCHI > wrote: >> Hello, this is just an entry mail for the next CF. >> >> The tap-test fails when the soruce directoy containing spaces. I >> accidentially hit this by a Jenkins project with the

Re: [HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-04 Thread Michael Paquier
On Mon, Jul 4, 2016 at 4:02 PM, Kyotaro HORIGUCHI wrote: > Hello, this is just an entry mail for the next CF. > > The tap-test fails when the soruce directoy containing spaces. I > accidentially hit this by a Jenkins project with the name "test > project". > > The function system_log() is safe for

[HACKERS] [CF2016-9] Allow spaces in working path on tap-tests

2016-07-04 Thread Kyotaro HORIGUCHI
Hello, this is just an entry mail for the next CF. The tap-test fails when the soruce directoy containing spaces. I accidentially hit this by a Jenkins project with the name "test project". The function system_log() is safe for such parameters but backup() uses it in wrong way. On the other hand,