Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-25 Thread Robert Haas
On Thu, Jun 24, 2010 at 11:50 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Jun 24, 2010 at 1:38 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-06-24 at 11:15 -0400, Tom Lane wrote: It might be a good idea to add a sentence to the

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Simon Riggs
On Wed, 2010-06-23 at 21:54 +, Robert Haas wrote: Log Message: --- Add TCP keepalive support to libpq. I misunderstood the earlier discussion on this and didn't realise you were considering committing in this way. For me, this is two patches, not one. I object to one and like the

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Wed, 2010-06-23 at 21:54 +, Robert Haas wrote: This adds four additional connection parameters to libpq: keepalives, keepalives_idle, keepalives_count, and keepalives_interval. keepalives default to on, per discussion, but can be turned off by

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Robert Haas
On Thu, Jun 24, 2010 at 10:13 AM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: On Wed, 2010-06-23 at 21:54 +, Robert Haas wrote: This adds four additional connection parameters to libpq: keepalives, keepalives_idle, keepalives_count, and keepalives_interval.

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Florian Pflug
On Jun 24, 2010, at 16:30 , Robert Haas wrote: On Thu, Jun 24, 2010 at 10:13 AM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: On Wed, 2010-06-23 at 21:54 +, Robert Haas wrote: This adds four additional connection parameters to libpq: keepalives,

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Robert Haas
On Thu, Jun 24, 2010 at 10:40 AM, Florian Pflug f...@phlo.org wrote: On Jun 24, 2010, at 16:30 , Robert Haas wrote: On Thu, Jun 24, 2010 at 10:13 AM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: There isn't any need at at all for this. We can already add options

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Florian Pflug
On Jun 24, 2010, at 16:45 , Robert Haas wrote: On Thu, Jun 24, 2010 at 10:40 AM, Florian Pflug f...@phlo.org wrote: On Jun 24, 2010, at 16:30 , Robert Haas wrote: On Thu, Jun 24, 2010 at 10:13 AM, Tom Lane t...@sss.pgh.pa.us wrote: Simon Riggs si...@2ndquadrant.com writes: There isn't any

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Tom Lane
Florian Pflug f...@phlo.org writes: On Jun 24, 2010, at 16:45 , Robert Haas wrote: I think the existing names are fine - people should understand that options means server-side options and that anything else is a client-side option. However, if there's a strong consensus the other way and

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Simon Riggs
On Thu, 2010-06-24 at 11:15 -0400, Tom Lane wrote: Florian Pflug f...@phlo.org writes: On Jun 24, 2010, at 16:45 , Robert Haas wrote: I think the existing names are fine - people should understand that options means server-side options and that anything else is a client-side option.

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Simon Riggs
On Thu, 2010-06-24 at 10:30 -0400, Robert Haas wrote: It lets you set the TCP keepalive parameters on the server side, whereas what this patch does is let you set them on the client side. Only setting them on the client side will allow the client to notice when the server has gone away.

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Robert Haas
On Thu, Jun 24, 2010 at 1:40 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-06-24 at 10:30 -0400, Robert Haas wrote: It lets you set the TCP keepalive parameters on the server side, whereas what this patch does is let you set them on the client side.  Only setting them on the

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Robert Haas
On Thu, Jun 24, 2010 at 1:38 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-06-24 at 11:15 -0400, Tom Lane wrote: Florian Pflug f...@phlo.org writes: On Jun 24, 2010, at 16:45 , Robert Haas wrote: I think the existing names are fine - people should understand that options means

Re: [HACKERS] [COMMITTERS] pgsql: Add TCP keepalive support to libpq.

2010-06-24 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Jun 24, 2010 at 1:38 PM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2010-06-24 at 11:15 -0400, Tom Lane wrote: It might be a good idea to add a sentence to the documentation, though, just pointing out that these control client-side