Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-27 Thread Peter Eisentraut
On tor, 2012-02-09 at 13:30 -0500, Tom Lane wrote:
  Also, we should at least do the attached to simplify the process.
  +check:
  + $(top_srcdir)/src/tools/check_keywords.pl $(top_srcdir)
 
 Actually, what would make sense in that line is to attach it to the
 existing maintainer-check target, no?  I don't think top-level
 make check descends into this directory.

I have hooked this into maintainer-check now.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-12 Thread Heikki Linnakangas

On 11.02.2012 11:57, Alex Hunsaker wrote:

On Thu, Feb 9, 2012 at 11:30, Tom Lanet...@sss.pgh.pa.us  wrote:

Alvaro Herreraalvhe...@commandprompt.com  writes:

Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012:



FWIW that script is throwing a warning here:
Use of assignment to $[ is deprecated at 
/pgsql/source/HEAD/src/tools/check_keywords.pl line 19.


Any Perl hackers want to improve that script?


The attached 2 liner does it for me.


Thanks, applied!

--
  Heikki Linnakangas
  EnterpriseDB   http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-11 Thread Alex Hunsaker
On Thu, Feb 9, 2012 at 11:30, Tom Lane t...@sss.pgh.pa.us wrote:
 Alvaro Herrera alvhe...@commandprompt.com writes:
 Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012:

 FWIW that script is throwing a warning here:
 Use of assignment to $[ is deprecated at 
 /pgsql/source/HEAD/src/tools/check_keywords.pl line 19.

 Any Perl hackers want to improve that script?

The attached 2 liner does it for me.
*** a/src/tools/check_keywords.pl
--- b/src/tools/check_keywords.pl
***
*** 16,22  if (@ARGV) {
  	$path = .;
  }
  
- $[ = 1;			# set array base to 1
  $, = ' ';		# set output field separator
  $\ = \n;		# set output record separator
  
--- 16,21 
***
*** 60,66  line: while (GRAM) {
  $n = (@arr = split(' ', $S));
  
  # Ok, we're in a keyword list. Go through each field in turn
! for (my $fieldIndexer = 1; $fieldIndexer = $n; $fieldIndexer++) {
  	if ($arr[$fieldIndexer] eq '*/'  $comment) {
  	$comment = 0;
  	next;
--- 59,65 
  $n = (@arr = split(' ', $S));
  
  # Ok, we're in a keyword list. Go through each field in turn
! for (my $fieldIndexer = 0; $fieldIndexer  $n; $fieldIndexer++) {
  	if ($arr[$fieldIndexer] eq '*/'  $comment) {
  	$comment = 0;
  	next;

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Alvaro Herrera

Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 2012:
 Add new keywords SNAPSHOT and TYPES to the keyword list in gram.y
 
 These were added to kwlist.h as unreserved keywords in separate patches,
 but authors forgot to add them to the corresponding list in gram.y.
 Because of that, even though they were supposed to be unreserved keywords,
 they could not be used as identifiers. src/tools/check_keywords.pl is your
 friend.

I wondered a couple of weeks ago if we could, instead, generate the
lists in gram.y from kwlist.h.

-- 
Álvaro Herrera alvhe...@commandprompt.com
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes:
 Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 2012:
 src/tools/check_keywords.pl is your friend.

 I wondered a couple of weeks ago if we could, instead, generate the
 lists in gram.y from kwlist.h.

We've looked into that in the past.  bison does not seem to have any
sort of include directive, which means the only way to do it would be
to have the gram.y file be built from pieces at compile time.  Although
Michael is successfully doing something of the sort for ecpg, I find it
way too ugly in return for the amount of benefit we'd get.

If people are sufficiently worried about this, a better answer would be
to teach the makefiles to run check_keywords.pl during every build.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Alvaro Herrera
Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012:
 
 Alvaro Herrera alvhe...@commandprompt.com writes:
  Excerpts from Heikki Linnakangas's message of jue feb 09 06:42:12 -0300 
  2012:
  src/tools/check_keywords.pl is your friend.
 
  I wondered a couple of weeks ago if we could, instead, generate the
  lists in gram.y from kwlist.h.
 
 We've looked into that in the past.  bison does not seem to have any
 sort of include directive, which means the only way to do it would be
 to have the gram.y file be built from pieces at compile time.

Doh, bummer.

 Although
 Michael is successfully doing something of the sort for ecpg, I find it
 way too ugly in return for the amount of benefit we'd get.

Agreed.

 If people are sufficiently worried about this, a better answer would be
 to teach the makefiles to run check_keywords.pl during every build.

FWIW that script is throwing a warning here:
Use of assignment to $[ is deprecated at 
/pgsql/source/HEAD/src/tools/check_keywords.pl line 19.

Also, we should at least do the attached to simplify the process.

-- 
Álvaro Herrera alvhe...@commandprompt.com
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support


check-keywords.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

2012-02-09 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes:
 Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012:
 If people are sufficiently worried about this, a better answer would be
 to teach the makefiles to run check_keywords.pl during every build.

 FWIW that script is throwing a warning here:
 Use of assignment to $[ is deprecated at 
 /pgsql/source/HEAD/src/tools/check_keywords.pl line 19.

Any Perl hackers want to improve that script?

 Also, we should at least do the attached to simplify the process.
 +check:
 + $(top_srcdir)/src/tools/check_keywords.pl $(top_srcdir)

Actually, what would make sense in that line is to attach it to the
existing maintainer-check target, no?  I don't think top-level
make check descends into this directory.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers