Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-14 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Andres Freund writes: > > I don't mind the new output, but I kinda wonder whether it's a good idea > > to include the '.s.PGSQL.5432' bit in the host and/or whether we > > shouldn't include the port in the TCP cases as well > > Yeah,

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Tom Lane
Andres Freund writes: > I don't mind the new output, but I kinda wonder whether it's a good idea > to include the '.s.PGSQL.5432' bit in the host and/or whether we > shouldn't include the port in the TCP cases as well Yeah, I've been thinking that maybe it should look like

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Andres Freund
On 2017-03-13 10:12:42 -0400, Robert Haas wrote: > So now on every startup I get this: > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address > "127.0.0.1" > 2017-03-13 10:08:49.400 EDT [90059] LOG:

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: > Tom Lane wrote: > > Robert Haas writes: > > > So now on every startup I get this: > > > > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > > > 2017-03-13 10:08:49.399 EDT [90059] LOG:

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Tom Lane
Alvaro Herrera writes: > I think it's good to have it, but I would argue that it should be a > single line that lists all the addresses instead. I don't think that's a terribly good idea, for the reasons I mentioned in

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Alvaro Herrera
Tom Lane wrote: > Robert Haas writes: > > So now on every startup I get this: > > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address > > "127.0.0.1" > > 2017-03-13

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Tom Lane
Robert Haas writes: > So now on every startup I get this: > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv6 address "::1" > 2017-03-13 10:08:49.399 EDT [90059] LOG: listening on IPv4 address > "127.0.0.1" > 2017-03-13 10:08:49.400 EDT [90059] LOG: listening

Re: [HACKERS] [COMMITTERS] pgsql: Improve postmaster's logging of listen socket creation.

2017-03-13 Thread Robert Haas
On Fri, Mar 10, 2017 at 4:32 PM, Tom Lane wrote: > Improve postmaster's logging of listen socket creation. > > When one of the kernel calls in the socket()/bind()/listen() sequence > fails, include the specific address we're trying to bind to in the log > message. This