Re: [HACKERS] [COMMITTERS] pgsql: Un-break pg_dump for the case of zero-column tables.

2010-02-24 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: 2010/2/24 Tom Lane t...@postgresql.org: Log Message: --- Un-break pg_dump for the case of zero-column tables. This was evidently broken by the CREATE TABLE OF TYPE patch.  It would have been noticed if anyone had bothered to try dumping

Re: [HACKERS] [COMMITTERS] pgsql: Un-break pg_dump for the case of zero-column tables.

2010-02-24 Thread Bruce Momjian
Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: 2010/2/24 Tom Lane t...@postgresql.org: Log Message: --- Un-break pg_dump for the case of zero-column tables. This was evidently broken by the CREATE TABLE OF TYPE patch. ?It would have been noticed if anyone had

Re: [HACKERS] [COMMITTERS] pgsql: Un-break pg_dump for the case of zero-column tables.

2010-02-24 Thread Andrew Dunstan
Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: 2010/2/24 Tom Lane t...@postgresql.org: Log Message: --- Un-break pg_dump for the case of zero-column tables. This was evidently broken by the CREATE TABLE OF TYPE patch. It would have been noticed if anyone had

Re: [HACKERS] [COMMITTERS] pgsql: Un-break pg_dump for the case of zero-column tables.

2010-02-24 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: I think it would make sense to add it as a buildfarm phase, probably after installcheck not check so you still have a working postmaster. I'm not sure how easy it'd be to automate though. What I usually do is make a text dump,