Re: [HACKERS] [COMMITTERS] pgsql: Unify some tar functionality across different parts

2013-01-02 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Wed, Jan 2, 2013 at 4:14 AM, Andrew Dunstan and...@dunslane.net wrote: This seems to have broken plperl builds on Windows. I'm not really sure what the best thing is to do here. We can either use the fact that we know that uid_t and gid_t are int

Re: [HACKERS] [COMMITTERS] pgsql: Unify some tar functionality across different parts

2013-01-02 Thread Magnus Hagander
On Wed, Jan 2, 2013 at 5:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Wed, Jan 2, 2013 at 4:14 AM, Andrew Dunstan and...@dunslane.net wrote: This seems to have broken plperl builds on Windows. I'm not really sure what the best thing is to do here.

Re: [HACKERS] [COMMITTERS] pgsql: Unify some tar functionality across different parts

2013-01-02 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Wed, Jan 2, 2013 at 5:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: Why are these very tar-specific functions being declared in such a globally visible spot as port.h? That seems like a bad idea on its face. IMO stuff in port.h ought to be about as

Re: [HACKERS] [COMMITTERS] pgsql: Unify some tar functionality across different parts

2013-01-02 Thread Magnus Hagander
On Wed, Jan 2, 2013 at 5:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Wed, Jan 2, 2013 at 5:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: Why are these very tar-specific functions being declared in such a globally visible spot as port.h? That seems like