Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-24 Thread Oliver Jowett
On 25 November 2011 07:54, Mikko Tiihonen wrote: > <=BE ParameterStatus(binary_minor = 23) > FE=> Execute(SET binary_minor = 20) Yeah this was almost exactly what I was thinking about how to retrofit it, except it might be clearer to have, say, "supported_binary_minor" (read-only, advertised by

Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-24 Thread Mikko Tiihonen
On 11/24/2011 02:36 AM, Kevin Grittner wrote: Oliver Jowett wrote: Can we get a mechanism for minor protocol changes in this future version? Something as simple as exchanging a list of protocol features during the initial handshake (then use only features that are present on both sides) would

Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-23 Thread Kevin Grittner
Oliver Jowett wrote: > Can we get a mechanism for minor protocol changes in this future > version? Something as simple as exchanging a list of protocol > features during the initial handshake (then use only features that > are present on both sides) would be enough. The difficulty of > making an

Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-23 Thread Oliver Jowett
On 24 November 2011 05:36, Tom Lane wrote: > Now it's possible we could do that without formally calling it a > protocol version change, but I don't care at all for the idea of coming > up with one-off hacks every time somebody decides that some feature is > important enough that they have to hav

Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-23 Thread Tom Lane
Merlin Moncure writes: > On Tue, Nov 22, 2011 at 6:52 PM, Tom Lane wrote: >> The only way that anything like this will go in is as part of a protocol >> version bump, > Wire format changes can only be made with a protocol version bump? Is > this a new policy? In the past they were just made...f

Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-23 Thread Merlin Moncure
On Tue, Nov 22, 2011 at 6:52 PM, Tom Lane wrote: > Oliver Jowett writes: >> On 23 November 2011 10:47, Mikko Tiihonen >> wrote: >>> Here is a patch that adds a new flag to the protocol that is set when all >>> elements of the array are of same fixed size. > >> How does a client detect that this

Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-22 Thread Tom Lane
Oliver Jowett writes: > On 23 November 2011 10:47, Mikko Tiihonen > wrote: >> Here is a patch that adds a new flag to the protocol that is set when all >> elements of the array are of same fixed size. > How does a client detect that this feature is supported? The only way that anything like thi

Re: [HACKERS] [JDBC] Optimize postgres protocol for fixed size arrays

2011-11-22 Thread Oliver Jowett
On 23 November 2011 10:47, Mikko Tiihonen wrote: > Here is a patch that adds a new flag to the protocol that is set when all > elements of the array are of same fixed size. > When the bit is set the 4 byte length is only sent once and not for each > element. Another restriction is that the flag >