Re: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module

2017-09-18 Thread Andrew Dunstan
On 09/18/2017 12:50 PM, Tom Lane wrote: > Alexey Chernyshov writes: >> Do we need expected/citext.out? It seems that only >> expected/citext_1.out has correct output. > Well, for me, citext.out matches the results in C locale, > and citext_1.out matches the results

Re: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module

2017-09-18 Thread Tom Lane
Alexey Chernyshov writes: > Do we need expected/citext.out? It seems that only > expected/citext_1.out has correct output. Well, for me, citext.out matches the results in C locale, and citext_1.out matches the results in en_US. If you don't satisfy both of those

Re: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module

2017-09-14 Thread Alexey Chernyshov
On Tue, 12 Sep 2017 12:59:20 -0400 Tom Lane wrote: > Quick comment on this patch: recently, we've decided that having > patches replace the whole base script for an extension is too much of > a maintenance problem, especially when there are several patches in > the pipeline

Re: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module

2017-09-12 Thread Tom Lane
Alexey Chernyshov writes: > The attached patch introduces citext_pattern_ops for citext extension > type like text_pattern_ops for text type. Here are operators ~<~, ~<=~, > ~>~, ~>=~ combined into citext_pattern_ops operator class. These > operators simply compare

Re: [HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module

2017-09-06 Thread Jacob Champion
On Tue, Jul 18, 2017 at 5:18 AM, Alexey Chernyshov wrote: > Hi all, Hi Alexey, I took a look at your patch. Builds fine here, and passes the new tests. I'm new to this code, so take my review with a grain of salt. > The attached patch introduces citext_pattern_ops

[HACKERS] [PATCH] Add citext_pattern_ops to citext contrib module

2017-07-18 Thread Alexey Chernyshov
Hi all, The attached patch introduces citext_pattern_ops for citext extension type like text_pattern_ops for text type. Here are operators ~<~, ~<=~, ~>~, ~>=~ combined into citext_pattern_ops operator class. These operators simply compare underlying citext values as C strings with memcmp()