Re: [HACKERS] [PATCH] Fix float8 parsing of denormal values (on some platforms?)

2012-02-03 Thread Tom Lane
Marti Raudsepp ma...@juffo.org writes: We're already seeing first buildfarm failures, on system narwhal using an msys/mingw compiler. Yeah. After a full day's cycle, the answer seems to be that denormalized input works fine everywhere except: 1. mingw on Windows (even though MSVC builds work)

Re: [HACKERS] [PATCH] Fix float8 parsing of denormal values (on some platforms?)

2012-02-03 Thread Andrew Dunstan
On 02/03/2012 03:49 AM, Tom Lane wrote: Marti Raudseppma...@juffo.org writes: We're already seeing first buildfarm failures, on system narwhal using an msys/mingw compiler. Yeah. After a full day's cycle, the answer seems to be that denormalized input works fine everywhere except: 1.

Re: [HACKERS] [PATCH] Fix float8 parsing of denormal values (on some platforms?)

2012-02-02 Thread Marti Raudsepp
On Wed, Feb 1, 2012 at 20:17, Tom Lane t...@sss.pgh.pa.us wrote: Applied with minor revisions. Thanks! :) We're already seeing first buildfarm failures, on system narwhal using an msys/mingw compiler. http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=narwhaldt=2012-02-02%2005%3A00%3A02 No idea

Re: [HACKERS] [PATCH] Fix float8 parsing of denormal values (on some platforms?)

2012-02-01 Thread Tom Lane
Marti Raudsepp ma...@juffo.org writes: On Wed, Dec 21, 2011 at 18:21, Marti Raudsepp ma...@juffo.org wrote: I think the least invasive fix, as proposed by Jeroen, is to fail only when ERANGE is set *and* the return value is 0.0 or +/-HUGE_VAL. Reading relevant specifications, this seems to be

[HACKERS] [PATCH] Fix float8 parsing of denormal values (on some platforms?)

2011-12-21 Thread Marti Raudsepp
Hi list, Back in June we had a discussion about parsing denormal floating-point values. A float8-text conversion could result in a number that can't be converted back to float8 anymore for some values. Among other things, this could break backups (though my searches didn't turn up any reports of

Re: [HACKERS] [PATCH] Fix float8 parsing of denormal values (on some platforms?)

2011-12-21 Thread Marti Raudsepp
On Wed, Dec 21, 2011 at 18:21, Marti Raudsepp ma...@juffo.org wrote: I think the least invasive fix, as proposed by Jeroen, is to fail only when ERANGE is set *and* the return value is 0.0 or +/-HUGE_VAL. Reading relevant specifications, this seems to be a fairly safe assumption. That's what