Re: [HACKERS] [PATCH] Refactoring: rename md5Salt to pwsalt

2016-09-30 Thread Michael Paquier
On Fri, Sep 30, 2016 at 9:40 PM, Tom Lane wrote: > Aleksander Alekseev writes: >> Suggested patch (first of many, I hope) renames `md5Salt` to more >> general `pwsalt`. >> Does it sound reasonable? > > I'm dubious. The main problem with supposing

Re: [HACKERS] [PATCH] Refactoring: rename md5Salt to pwsalt

2016-09-30 Thread Tom Lane
Aleksander Alekseev writes: > Suggested patch (first of many, I hope) renames `md5Salt` to more > general `pwsalt`. > Does it sound reasonable? I'm dubious. The main problem with supposing that port->md5Salt can serve other purposes is its fixed size. I think you're

[HACKERS] [PATCH] Refactoring: rename md5Salt to pwsalt

2016-09-30 Thread Aleksander Alekseev
Hello. Since there are plans/efforts to introduce additional authorization methods in nearest feature I suggest to refactor the code so it wouldn't mention md5 when it possible. `md5Salt` for instance could be not only "md5 salt" but also "sha2 salt", etc - depending on what authorization method