Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-10 Thread Dagfinn Ilmari Mannsåker
Jeff Janes writes: > On Thu, Mar 9, 2017 at 3:20 PM, Robert Haas wrote: > >> Committed. Hopefully this doesn't contain any Perl bits that are >> sufficiently new as to cause problems for our older BF members ... I >> guess we'll see. > > Bad luck

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-09 Thread Robert Haas
On Thu, Mar 9, 2017 at 8:47 PM, Tom Lane wrote: > Amit Langote writes: >> On 2017/03/10 9:14, Jeff Janes wrote: >>> I think we can just save $. and use that, as in the attached. > >> The patch works for me. > > Me too. Pushed; we'll soon see if

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-09 Thread Tom Lane
Amit Langote writes: > On 2017/03/10 9:14, Jeff Janes wrote: >> I think we can just save $. and use that, as in the attached. > The patch works for me. Me too. Pushed; we'll soon see if that makes the oldest buildfarm critters happy.

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-09 Thread Amit Langote
On 2017/03/10 9:14, Jeff Janes wrote: > On Thu, Mar 9, 2017 at 3:20 PM, Robert Haas > wrote: > > On Mon, Mar 6, 2017 at 11:37 AM, Dagfinn Ilmari Mannsåker > > wrote: > > David

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-09 Thread Jeff Janes
On Thu, Mar 9, 2017 at 3:20 PM, Robert Haas wrote: > On Mon, Mar 6, 2017 at 11:37 AM, Dagfinn Ilmari Mannsåker > wrote: > > David Christensen writes: > >>> Hi David, > >>> > >>> Here's a review of your patch. > >> > >> Hi Ilmari,

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-09 Thread Robert Haas
On Mon, Mar 6, 2017 at 11:37 AM, Dagfinn Ilmari Mannsåker wrote: > David Christensen writes: >>> Hi David, >>> >>> Here's a review of your patch. >> >> Hi Ilmari, thanks for your time and review. I’m fine with the revised >> version. > > Okay, I've marked

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-06 Thread Dagfinn Ilmari Mannsåker
David Christensen writes: >> Hi David, >> >> Here's a review of your patch. > > Hi Ilmari, thanks for your time and review. I’m fine with the revised > version. Okay, I've marked the patch as Ready For Committer. Thanks, Ilmari -- "The surreality of the universe tends

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-03-06 Thread Dagfinn Ilmari Mannsåker
Hi David, Here's a review of your patch. David Christensen writes: > Throws a build error if we encounter a different number of fields in a > DATA() line than we expect for the catalog in question. The patch is a good idea, and as-is implements the suggested feature.

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-02-17 Thread Peter Eisentraut
On 2/15/17 10:40, David Christensen wrote: > Throws a build error if we encounter a different number of fields in a > DATA() line than we expect for the catalog in question. > > Previously, it was possible to silently ignore any mismatches at build > time which could result in symbol undefined

[HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2017-02-15 Thread David Christensen
Throws a build error if we encounter a different number of fields in a DATA() line than we expect for the catalog in question. Previously, it was possible to silently ignore any mismatches at build time which could result in symbol undefined errors at link time. Now we stop and identify the

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2015-10-09 Thread David Christensen
> On Oct 9, 2015, at 2:17 PM, Robert Haas wrote: > > On Thu, Oct 8, 2015 at 12:43 PM, David Christensen wrote: >> I’m happy to move it around, but If everything is in order, how will this >> affect things at all? If we’re in a good state this

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2015-10-09 Thread Robert Haas
On Thu, Oct 8, 2015 at 12:43 PM, David Christensen wrote: > I’m happy to move it around, but If everything is in order, how will this > affect things at all? If we’re in a good state this condition should never > trigger. Right, but I think it ought to be Catalog.pm's job

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2015-10-08 Thread Robert Haas
On Tue, Oct 6, 2015 at 9:15 AM, David Christensen wrote: > Fixes a build issue I ran into while adding some columns to system tables: > > Throws a build error if we encounter a different number of fields in a > DATA() line than we expect for the catalog in question. >

Re: [HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2015-10-08 Thread David Christensen
> On Oct 8, 2015, at 11:23 AM, Robert Haas wrote: > > On Tue, Oct 6, 2015 at 9:15 AM, David Christensen wrote: >> Fixes a build issue I ran into while adding some columns to system tables: >> >>Throws a build error if we encounter a different

[HACKERS] [PATCH] Teach Catalog.pm how many attributes there should be per DATA() line

2015-10-06 Thread David Christensen
Fixes a build issue I ran into while adding some columns to system tables: Throws a build error if we encounter a different number of fields in a DATA() line than we expect for the catalog in question. Previously, it was possible to silently ignore any mismatches at build