Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-12 Thread Tsutomu Yamada
Thank you very much for refining patch. I thought there is no missing part. Magnus Hagander mag...@hagander.net wrote: On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: The following patches support Windows x64. 1) use intptr_t for Datum and pointer macros. (to

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-10 Thread Magnus Hagander
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: The following patches support Windows x64. 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)   almost the same as that post before.  

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-10 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: I was checked where the string converted with %ld is used. An especially fatal part is not found excluding one of plperl. I have not looked at the plperl stuff yet. I'd

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-05 Thread Tsutomu Yamada
Magnus Hagander mag...@hagander.net wrote: On Fri, Jan 1, 2010 at 20:45, Magnus Hagander mag...@hagander.net wrote: On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: 2) use appropriate macro and datatypes for Windows API. enables more than 32bits shared

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-05 Thread Magnus Hagander
On Tue, Jan 5, 2010 at 09:14, Tsutomu Yamada tsut...@sraoss.co.jp wrote: Magnus Hagander mag...@hagander.net wrote:   On Fri, Jan 1, 2010 at 20:45, Magnus Hagander mag...@hagander.net wrote:   On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote:     2) use appropriate

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-05 Thread Tsutomu Yamada
Magnus Hagander mag...@hagander.net wrote: 2009/12/4 Tsutomu Yamada tsut...@sraoss.co.jp: Thanks to suggestion. I send pathces again by another mailer for the archive. Sorry to waste resources, below is same content that I send before. I have a couple of comments about the

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-05 Thread Magnus Hagander
On Tue, Jan 5, 2010 at 12:58, Tsutomu Yamada tsut...@sraoss.co.jp wrote: Magnus Hagander mag...@hagander.net wrote:   2009/12/4 Tsutomu Yamada tsut...@sraoss.co.jp:   Thanks to suggestion.   I send pathces again by another mailer for the archive.     Sorry to waste resources, below is

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-04 Thread Magnus Hagander
On Fri, Jan 1, 2010 at 20:45, Magnus Hagander mag...@hagander.net wrote: On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: 2) use appropriate macro and datatypes for Windows API.   enables more than 32bits shared memory. Are you sure this one should use __noop, and not

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-01 Thread Magnus Hagander
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: 2) use appropriate macro and datatypes for Windows API.   enables more than 32bits shared memory. Are you sure this one should use __noop, and not __nop? __noop: http://msdn.microsoft.com/en-us/library/s6btaxcs.aspx

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-31 Thread Magnus Hagander
2009/12/31 Magnus Hagander mag...@hagander.net: 2009/12/4 Tsutomu Yamada tsut...@sraoss.co.jp: A bit further down, it has: + /* The size of `void *', as computed by sizeof. */ + #define SIZEOF_VOID_P 4 + shouldn't that be 8 for win64 platforms? Nevermind this second comment. Now that

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-30 Thread Magnus Hagander
2009/12/4 Tsutomu Yamada tsut...@sraoss.co.jp: Thanks to suggestion. I send pathces again by another mailer for the archive. Sorry to waste resources, below is same content that I send before. I have a couple of comments about the first patch (I'll get to the others later): config.win32.h

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-09 Thread Massa, Harald Armin
Tatsuo, Ok. Your suggestion is very helpfull. In general Tsutomu will wait for feedbacks come in, probably until Jan 15th. BTW, is there anyone who wishes the patches get in 8.5? Apparently Tstutomu, Magnus and I are counted in the group:-) But I'd like to know how other people are

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-09 Thread Dave Page
On Wed, Dec 9, 2009 at 8:31 AM, Massa, Harald Armin c...@ghum.de wrote: Tatsuo, Ok. Your suggestion is very helpfull. In general Tsutomu will wait for feedbacks come in, probably until Jan 15th. BTW, is there anyone who wishes the patches get in 8.5? Apparently Tstutomu, Magnus and I are

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-09 Thread Tatsuo Ishii
Tatsuo, Ok. Your suggestion is very helpfull. In general Tsutomu will wait for feedbacks come in, probably until Jan 15th. BTW, is there anyone who wishes the patches get in 8.5? Apparently Tstutomu, Magnus and I are counted in the group:-) But I'd like to know how other people are

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-09 Thread Tatsuo Ishii
BTW, is there anyone who wishes the patches get in 8.5? Apparently Tstutomu, Magnus and I are counted in the group:-) But I'd like to know how other people are interested in the patches. I am very interested. A 64bit-Windows-Version would give a boost perception-wise I'm also very

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-09 Thread Magnus Hagander
2009/12/9 Tatsuo Ishii is...@postgresql.org: Ok. Your suggestion is very helpfull. In general Tsutomu will wait for feedbacks come in, probably until Jan 15th. Of course there's also no rule that you couldn't review these sooner - that might help get the ball rolling! Of course I did

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-09 Thread Tatsuo Ishii
As a reference for the future, please let us know when you have done this before the patch is submitted. I think it's not very common that just because you are in the same company, you have reviewed it. For example, I highly doubt that Heikki reviews all the patches Bruce post, or the other

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-08 Thread Tatsuo Ishii
Magnus, Just in case anybody was wondering, I've added myself as a reviewer of this one for next commitfest - I doubt that's very surprising :-) Others are of course more than welcome to chip in! Greg Smith wrote: There are also a couple of patches that for various reasons have yet to get

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-08 Thread Greg Smith
Tatsuo Ishii wrote: Now that Greg is going to close the Nov Commit Festa, I think he is requesting initial reviews for the patches. While Magnus might take a look anyway, in general we'll all be taking a break from review until January 15th, when the final CommitFest for this version

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-08 Thread Tatsuo Ishii
Tatsuo Ishii wrote: Now that Greg is going to close the Nov Commit Festa, I think he is requesting initial reviews for the patches. While Magnus might take a look anyway, in general we'll all be taking a break from review until January 15th, when the final CommitFest for this

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-08 Thread Robert Haas
On Tue, Dec 8, 2009 at 10:30 PM, Tatsuo Ishii is...@postgresql.org wrote: Tatsuo Ishii wrote: Now that Greg is going to close the Nov Commit Festa, I think he is requesting initial reviews for the patches. While Magnus might take a look anyway, in general we'll all be taking a break from

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-08 Thread Tatsuo Ishii
Ok. Your suggestion is very helpfull. In general Tsutomu will wait for feedbacks come in, probably until Jan 15th. Of course there's also no rule that you couldn't review these sooner - that might help get the ball rolling! Of course I did before he publishes the patches. (I and he are

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-08 Thread Robert Haas
On Tue, Dec 8, 2009 at 10:48 PM, Tatsuo Ishii is...@postgresql.org wrote: Ok. Your suggestion is very helpfull. In general Tsutomu will wait for feedbacks come in, probably until Jan 15th. Of course there's also no rule that you couldn't review these sooner - that might help get the ball

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-07 Thread Magnus Hagander
2009/12/4 Tsutomu Yamada tsut...@sraoss.co.jp: Thanks to suggestion. I send pathces again by another mailer for the archive. Sorry to waste resources, below is same content that I send before. Just in case anybody was wondering, I've added myself as a reviewer of this one for next commitfest

Re: [HACKERS] [PATCH] Windows x64 [repost]

2009-12-04 Thread Tsutomu Yamada
Thanks to suggestion. I send pathces again by another mailer for the archive. Sorry to waste resources, below is same content that I send before. Tsutomu Yamada SRA OSS, Inc. Japan # The following patches support Windows x64. 1) use intptr_t for Datum and pointer macros. (to support